-
Notifications
You must be signed in to change notification settings - Fork 37
wheels: build with CUDA 13.0, test against mix of CTK versions, make 'torch-geometric' fully optional for 'cugraph-pyg' #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
5e079d2
68159a5
ba16e2d
13ef184
9c60899
73048fd
06d75a4
3c01d1c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,8 +25,10 @@ jobs: | |
| - wheel-build-libwholegraph | ||
| - wheel-build-pylibwholegraph | ||
| - wheel-tests-pylibwholegraph | ||
| - wheel-tests-nightly-pylibwholegraph | ||
| - wheel-build-cugraph-pyg | ||
| - wheel-tests-cugraph-pyg | ||
| - wheel-tests-nightly-cugraph-pyg | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is pretty close!
I'll try to reproduce that locally and see if I can get a better solver error.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm able to reproduce this locally code to do that (click me)docker run \
--rm \
--pull always \
--env RAPIDS_REPOSITORY=rapidsai/cugraph-gnn \
--env RAPIDS_SHA=13ef184fcfbeab41e096fa643f1ff082a3127ccd \
--env RAPIDS_REF_NAME=pull-request/434 \
--env RAPIDS_BUILD_TYPE=pull-request \
-v $(pwd):/opt/work \
-w /opt/work \
-it rapidsai/citestwheel:26.04-cuda12.2.2-ubuntu22.04-py3.11 \
bash
source rapids-init-pip
package_name="cugraph-pyg"
RAPIDS_PY_CUDA_SUFFIX="$(rapids-wheel-ctk-name-gen ${RAPIDS_CUDA_VERSION})"
# Download the libwholegraph, pylibwholegraph, and cugraph-pyg built in the previous step
LIBWHOLEGRAPH_WHEELHOUSE=$(RAPIDS_PY_WHEEL_NAME="libwholegraph_${RAPIDS_PY_CUDA_SUFFIX}" rapids-download-wheels-from-github cpp)
PYLIBWHOLEGRAPH_WHEELHOUSE=$(rapids-download-from-github "$(rapids-package-name "wheel_python" pylibwholegraph --stable --cuda "$RAPIDS_CUDA_VERSION")")
CUGRAPH_PYG_WHEELHOUSE=$(RAPIDS_PY_WHEEL_NAME="${package_name}_${RAPIDS_PY_CUDA_SUFFIX}" RAPIDS_PY_WHEEL_PURE="1" rapids-download-wheels-from-github python)
# generate constraints (possibly pinning to oldest support versions of dependencies)
rapids-generate-pip-constraints test_cugraph_pyg "${PIP_CONSTRAINT}"
rapids-generate-pip-constraints torch_only "${PIP_CONSTRAINT}"
rapids-pip-retry install \
--prefer-binary \
--constraint "${PIP_CONSTRAINT}" \
--extra-index-url 'https://pypi.nvidia.com' \
"${LIBWHOLEGRAPH_WHEELHOUSE}"/*.whl \
"$(echo "${PYLIBWHOLEGRAPH_WHEELHOUSE}"/pylibwholegraph_"${RAPIDS_PY_CUDA_SUFFIX}"*.whl)" \
"$(echo "${CUGRAPH_PYG_WHEELHOUSE}"/cugraph_pyg_"${RAPIDS_PY_CUDA_SUFFIX}"*.whl)[test]"I think I see what's happening.
Taken together, you end up in this "resolution-too-deep" situation, where Unfortunately I think the best long-term fix here is to treat
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Trying this in 9c60899
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Interestingly, still hitting a 'resolution-to-deep' error even without 'torch', 'ogb', or 'torch-geometric' in the solve: https://github.com/rapidsai/cugraph-gnn/actions/runs/23318288336/job/67824788071?pr=434 Will look more into this tomorrow. Maybe it's actually RAPIDS libraries that are causing the conflicts?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is with If so, maybe it is worth trying with
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks, I'll consider it.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I found the root cause... We really do not want Pushed that change and it looks like all CI Jobs (including all nightly wheels jobs!) are now passing: https://github.com/rapidsai/cugraph-gnn/actions/runs/23348691254/job/67923786458?pr=434 I'll revert the nightly stuff and go ask for a review. |
||
| secrets: inherit | ||
| uses: rapidsai/shared-workflows/.github/workflows/pr-builder.yaml@release/26.04 | ||
| if: always() | ||
|
|
@@ -259,6 +261,16 @@ jobs: | |
| build_type: pull-request | ||
| script: ci/test_wheel_pylibwholegraph.sh | ||
| matrix_filter: map(select(.PY_VER != "3.14")) | map(select(.ARCH == "amd64")) | ||
| wheel-tests-nightly-pylibwholegraph: | ||
| needs: [wheel-build-pylibwholegraph, changed-files] | ||
| secrets: inherit | ||
| uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@release/26.04 | ||
| if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python_wheels | ||
| with: | ||
| build_type: pull-request | ||
| script: ci/test_wheel_pylibwholegraph.sh | ||
| matrix_filter: map(select(.PY_VER != "3.14")) | map(select(.ARCH == "amd64")) | ||
| matrix_type: nightly | ||
| wheel-build-cugraph-pyg: | ||
| needs: checks | ||
| secrets: inherit | ||
|
|
@@ -281,3 +293,13 @@ jobs: | |
| build_type: pull-request | ||
| script: ci/test_wheel_cugraph-pyg.sh | ||
| matrix_filter: map(select(.PY_VER != "3.14")) | map(select(.ARCH == "amd64")) | ||
| wheel-tests-nightly-cugraph-pyg: | ||
| needs: [wheel-build-pylibwholegraph, wheel-build-cugraph-pyg, changed-files] | ||
| secrets: inherit | ||
| uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@release/26.04 | ||
| if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python_wheels | ||
| with: | ||
| build_type: pull-request | ||
| script: ci/test_wheel_cugraph-pyg.sh | ||
| matrix_filter: map(select(.PY_VER != "3.14")) | map(select(.ARCH == "amd64")) | ||
| matrix_type: nightly | ||
Uh oh!
There was an error while loading. Please reload this page.