Skip to content

Update rapids-dependency-file-generator#285

Merged
rapids-bot[bot] merged 7 commits intorapidsai:branch-25.10from
KyleFromNVIDIA:pre-commit-autoupdate
Aug 27, 2025
Merged

Update rapids-dependency-file-generator#285
rapids-bot[bot] merged 7 commits intorapidsai:branch-25.10from
KyleFromNVIDIA:pre-commit-autoupdate

Conversation

@KyleFromNVIDIA
Copy link
Member

@KyleFromNVIDIA KyleFromNVIDIA commented Aug 26, 2025

This PR updates the rapids-dependency-file-generator hook to get rapidsai/dependency-file-generator#163.

@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner August 26, 2025 18:19
@KyleFromNVIDIA KyleFromNVIDIA added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Aug 26, 2025
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏻 this caught something!

Traceback (most recent call last):
  File "/github/home/.cache/pre-commit/repoogqoa4r4/py_env-python3.13/bin/rapids-dependency-file-generator", line 7, in <module>
    sys.exit(main())
             ~~~~^^
  File "/github/home/.cache/pre-commit/repoogqoa4r4/py_env-python3.13/lib/python3.13/site-packages/rapids_dependency_file_generator/_cli.py", line 150, in main
    parsed_config = load_config_from_file(args.config)
  File "/github/home/.cache/pre-commit/repoogqoa4r4/py_env-python3.13/lib/python3.13/site-packages/rapids_dependency_file_generator/_config.py", line 264, in load_config_from_file
    return parse_config(yaml.safe_load(f), path)
  File "/github/home/.cache/pre-commit/repoogqoa4r4/py_env-python3.13/lib/python3.13/site-packages/rapids_dependency_file_generator/_config.py", line 241, in parse_config
    validate_dependencies(config)
    ~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
  File "/github/home/.cache/pre-commit/repoogqoa4r4/py_env-python3.13/lib/python3.13/site-packages/rapids_dependency_file_generator/_rapids_dependency_file_validator.py", line 44, in validate_dependencies
    warnings.warn(f'Dependency set "{dep}" is not referred to anywhere in "files:"', UnusedDependencySetWarning)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
rapids_dependency_file_generator._warnings.UnusedDependencySetWarning: Dependency set "python_run_libwholegraph" is not referred to anywhere in "files:"

(build link)

@jameslamb jameslamb removed the request for review from AyodeAwe August 26, 2025 19:09
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner August 26, 2025 19:17
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Investigating that unused python_run_libwholegraph revealed more unused stuff that should also get removed here.

Since we'll have another commit and round of CI anyway, let's also add .pre-commit-config.yaml to the changed-files configurations too:

Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jameslamb jameslamb removed the request for review from msarahan August 26, 2025 19:44
@jameslamb
Copy link
Member

Once we get #284 in, I'll manually re-trigger nightly tests. Hopefully those will pass and unblock the check-nightly-ci job here, and we'll be able to merge this normally.

@KyleFromNVIDIA
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 3d4c449 into rapidsai:branch-25.10 Aug 27, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments