Skip to content

split up CUDA-suffixed dependencies in dependencies.yaml#16

Merged
jameslamb merged 3 commits intorapidsai:branch-24.08from
jameslamb:suffix-split
Jul 25, 2024
Merged

split up CUDA-suffixed dependencies in dependencies.yaml#16
jameslamb merged 3 commits intorapidsai:branch-24.08from
jameslamb:suffix-split

Conversation

@jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#31

cugraph-gnn does not currently used rapids-build-backend, but this will help once it does. I wrote that up here: #15

In short, RAPIDS DLFW builds want to produce wheels with unsuffixed dependencies, e.g. cudf depending on rmm, not rmm-cu12.

This PR is part of a series across all of RAPIDS to try to support that type of build by setting up CUDA-suffixed and CUDA-unsuffixed dependency lists in dependencies.yaml.

For more details, see:

Notes for Reviewers

Why target 24.08?

This is targeting 24.08 because:

  1. it should be very low-risk
  2. getting these changes into 24.08 prevents the need to carry around patches for every library in DLFW builds using RAPIDS 24.08

- output_types: [conda]
packages:
- &pytorch_conda pytorch::pytorch>=2.0,<2.2.0a0
- &pytorch_unsuffixed pytorch::pytorch>=2.0,<2.2.0a0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PyTorch is never suffixed, right? Also this is a conda pinning since it includes a channel.

Suggested change
- &pytorch_unsuffixed pytorch::pytorch>=2.0,<2.2.0a0
- &pytorch_conda pytorch::pytorch>=2.0,<2.2.0a0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, this one was a mistake from being a little over-aggressive with find-and-replace.

I went to change this and found that this anchor is actually not used at all, so pushed c72b9b8 just fully removing it.

@jameslamb jameslamb merged commit fca4b79 into rapidsai:branch-24.08 Jul 25, 2024
@jameslamb jameslamb deleted the suffix-split branch July 25, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants