split up CUDA-suffixed dependencies in dependencies.yaml#16
Merged
jameslamb merged 3 commits intorapidsai:branch-24.08from Jul 25, 2024
jameslamb:suffix-split
Merged
split up CUDA-suffixed dependencies in dependencies.yaml#16jameslamb merged 3 commits intorapidsai:branch-24.08from jameslamb:suffix-split
jameslamb merged 3 commits intorapidsai:branch-24.08from
jameslamb:suffix-split
Conversation
This was referenced Jul 24, 2024
bdice
approved these changes
Jul 25, 2024
dependencies.yaml
Outdated
| - output_types: [conda] | ||
| packages: | ||
| - &pytorch_conda pytorch::pytorch>=2.0,<2.2.0a0 | ||
| - &pytorch_unsuffixed pytorch::pytorch>=2.0,<2.2.0a0 |
Contributor
There was a problem hiding this comment.
PyTorch is never suffixed, right? Also this is a conda pinning since it includes a channel.
Suggested change
| - &pytorch_unsuffixed pytorch::pytorch>=2.0,<2.2.0a0 | |
| - &pytorch_conda pytorch::pytorch>=2.0,<2.2.0a0 |
Member
Author
There was a problem hiding this comment.
You're right, this one was a mistake from being a little over-aggressive with find-and-replace.
I went to change this and found that this anchor is actually not used at all, so pushed c72b9b8 just fully removing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#31
cugraph-gnndoes not currently usedrapids-build-backend, but this will help once it does. I wrote that up here: #15In short, RAPIDS DLFW builds want to produce wheels with unsuffixed dependencies, e.g.
cudfdepending onrmm, notrmm-cu12.This PR is part of a series across all of RAPIDS to try to support that type of build by setting up CUDA-suffixed and CUDA-unsuffixed dependency lists in
dependencies.yaml.For more details, see:
Notes for Reviewers
Why target 24.08?
This is targeting 24.08 because: