Return count of set bits from inplace_bitmask_and.#9904
Merged
rapids-bot[bot] merged 10 commits intorapidsai:branch-22.02from Jan 12, 2022
Merged
Return count of set bits from inplace_bitmask_and.#9904rapids-bot[bot] merged 10 commits intorapidsai:branch-22.02from
rapids-bot[bot] merged 10 commits intorapidsai:branch-22.02from
Conversation
bdice
added
3 - Ready for Review
ttnghia
approved these changes
Dec 15, 2021
robertmaynard
requested changes
Dec 15, 2021
Contributor
robertmaynard
left a comment
robertmaynard
left a comment
There was a problem hiding this comment.
Some some small style changes
robertmaynard
approved these changes
Dec 15, 2021
…lace-bitmask-and-null-count
Contributor
Author
|
rerun tests |
1 similar comment
Contributor
Author
|
rerun tests |
…lace-bitmask-and-null-count
…lace-bitmask-and-null-count
…lace-bitmask-and-null-count
…erimpose_parent_nulls.
bdice
commented
Jan 12, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9904 +/- ##
================================================
- Coverage 10.49% 10.41% -0.08%
================================================
Files 119 119
Lines 20305 20498 +193
================================================
+ Hits 2130 2134 +4
- Misses 18175 18364 +189
Continue to review full report at Codecov.
|
Contributor
Author
|
@gpucibot merge |
bdice
changed the title
bdice
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the function
cudf::detail::inplace_bitmask_andto return the count of set bits in the result. This change alignsinplace_bitmask_andwith behavior changes introduced in #9616 to return counts of set bits (valid items in the nullmask) from functions acting on bitmasks. This will be helpful for #9621.