Skip to content

[WIP] fix print outputs in notebooks for 21.12#9866

Closed
taureandyernv wants to merge 1 commit intorapidsai:branch-21.12from
taureandyernv:patch-2
Closed

[WIP] fix print outputs in notebooks for 21.12#9866
taureandyernv wants to merge 1 commit intorapidsai:branch-21.12from
taureandyernv:patch-2

Conversation

@taureandyernv
Copy link
Contributor

Print actual outputs for the sparse_data instead <cupyx.scipy.sparse.csc.csc_matrix at 0x7f25e49466a0>

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #9866 (e11604a) into branch-21.12 (a93d333) will not change coverage.
The diff coverage is n/a.

❗ Current head e11604a differs from pull request most recent head 3117e81. Consider uploading reports for the commit 3117e81 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##           branch-21.12    #9866   +/-   ##
=============================================
  Coverage         10.60%   10.60%           
=============================================
  Files               118      118           
  Lines             20081    20081           
=============================================
  Hits               2130     2130           
  Misses            17951    17951           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a93d333...3117e81. Read the comment docs.

"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.8.6"
"version": "3.7.12"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep running under Python 3.8? Or is there a reason to use 3.7?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i ran it with the nightlies docker container running 3.7 python. Do you want me to revert it with 3.8?

@shwina
Copy link
Contributor

shwina commented Dec 8, 2021

Please note that the changes in this PR are being included in the hotfix PR #9870. @taureandyernv if you decide to push further commits to your patch-2 branch, I'll merge them into that PR. This PR can be closed at any time.

@github-actions
Copy link

github-actions bot commented Jan 8, 2022

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@shwina
Copy link
Contributor

shwina commented Jan 20, 2022

Closing as the changes in this PR were included in #9870.

@shwina shwina closed this Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants