Skip to content

Support out-of-band buffers in Python pickling #5132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkraus14 merged 4 commits into from
May 9, 2020
Merged

Support out-of-band buffers in Python pickling #5132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5b945e0
Store data transferred to host
jakirkham May 7, 2020
eeb3cc4
Implement `__reduce_ex__` instead of `__reduce__`
jakirkham May 7, 2020
cedf90a
Support out-of-band pickling when available
jakirkham May 7, 2020
1e2d39a
Note out-of-band buffers supported in pickling
jakirkham May 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
- PR #5072 Adding cython binding to `get_element`
- PR #4881 Support row_number in rolling_window
- PR #5068 Add Java bindings for arctan2
- PR #5132 Support out-of-band buffers in Python pickling

## Improvements

Expand Down
7 changes: 5 additions & 2 deletions python/cudf/cudf/core/buffer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,11 @@ def __init__(self, data=None, size=None, owner=None):
raise TypeError("data must be Buffer, array-like or integer")
self._init_from_array_like(np.asarray(data), owner)

def __reduce__(self):
return self.__class__, (self.to_host_array(),)
def __reduce_ex__(self, protocol):
data = self.to_host_array()
if protocol >= 5:
data = pickle.PickleBuffer(data)
return self.__class__, (data,)

def __len__(self):
return self.size
Expand Down