-
Notifications
You must be signed in to change notification settings - Fork 1k
WIP: wheels CI: write constraints directly to PIP_CONSTRAINT #21639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f6fcc93
wheels CI: write constraints directly to PIP_CONSTRAINT
jameslamb 7b3b87a
Merge branch 'main' into pip-constraints-append
jameslamb b953e49
Merge branch 'main' into pip-constraints-append
jameslamb 72e43ad
cudf_pands_scripts/run_tests.sh is special, keep using a custom const…
jameslamb 7f7b6a0
Merge branch 'main' of github.com:rapidsai/cudf into pip-constraints-…
jameslamb 2451dc4
test new behavior
jameslamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -4,6 +4,13 @@ | |||||||||||||
|
|
||||||||||||||
| set -euo pipefail | ||||||||||||||
|
|
||||||||||||||
| # TODO(jameslamb): revert before merging | ||||||||||||||
| git clone --branch generate-pip-constraints \ | ||||||||||||||
| https://github.com/rapidsai/gha-tools.git \ | ||||||||||||||
| /tmp/gha-tools | ||||||||||||||
|
|
||||||||||||||
| export PATH="/tmp/gha-tools/tools:${PATH}" | ||||||||||||||
|
|
||||||||||||||
|
Comment on lines
+7
to
+13
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||
| source rapids-init-pip | ||||||||||||||
|
|
||||||||||||||
| rapids-logger "Download wheels" | ||||||||||||||
|
|
@@ -18,17 +25,16 @@ PYLIBCUDF_WHEELHOUSE=$(rapids-download-from-github "$(rapids-package-name "wheel | |||||||||||||
| rapids-logger "Installing cudf_polars and its dependencies" | ||||||||||||||
|
|
||||||||||||||
| # generate constraints (possibly pinning to oldest support versions of dependencies) | ||||||||||||||
| rapids-generate-pip-constraints py_test_cudf_polars ./constraints.txt | ||||||||||||||
| rapids-generate-pip-constraints py_test_cudf_polars "${PIP_CONSTRAINT}" | ||||||||||||||
|
|
||||||||||||||
| # notes: | ||||||||||||||
| # | ||||||||||||||
| # * echo to expand wildcard before adding `[test,experimental]` requires for pip | ||||||||||||||
| # * need to provide --constraint="${PIP_CONSTRAINT}" because that environment variable is | ||||||||||||||
| # ignored if any other --constraint are passed via the CLI | ||||||||||||||
| # * echo to expand wildcard before adding `[test]` requires for pip | ||||||||||||||
| # * just providing --constraint="${PIP_CONSTRAINT}" to be explicit, and because | ||||||||||||||
| # that environment variable is ignored if any other --constraint are passed via the CLI | ||||||||||||||
| # | ||||||||||||||
| rapids-pip-retry install \ | ||||||||||||||
| -v \ | ||||||||||||||
| --constraint ./constraints.txt \ | ||||||||||||||
| --constraint "${PIP_CONSTRAINT}" \ | ||||||||||||||
| "$(echo "${CUDF_POLARS_WHEELHOUSE}"/cudf_polars_"${RAPIDS_PY_CUDA_SUFFIX}"*.whl)[test,experimental]" \ | ||||||||||||||
| "$(echo "${LIBCUDF_WHEELHOUSE}"/libcudf_"${RAPIDS_PY_CUDA_SUFFIX}"*.whl)" \ | ||||||||||||||
|
|
||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -4,6 +4,13 @@ | |||||||||||||
|
|
||||||||||||||
| set -euo pipefail | ||||||||||||||
|
|
||||||||||||||
| # TODO(jameslamb): revert before merging | ||||||||||||||
| git clone --branch generate-pip-constraints \ | ||||||||||||||
| https://github.com/rapidsai/gha-tools.git \ | ||||||||||||||
| /tmp/gha-tools | ||||||||||||||
|
|
||||||||||||||
| export PATH="/tmp/gha-tools/tools:${PATH}" | ||||||||||||||
|
|
||||||||||||||
|
Comment on lines
+7
to
+13
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||
| source rapids-init-pip | ||||||||||||||
|
|
||||||||||||||
| RAPIDS_PY_CUDA_SUFFIX="$(rapids-wheel-ctk-name-gen "${RAPIDS_CUDA_VERSION}")" | ||||||||||||||
|
|
@@ -17,17 +24,16 @@ PYLIBCUDF_WHEELHOUSE=$(rapids-download-from-github "$(rapids-package-name "wheel | |||||||||||||
| rapids-logger "Install dask_cudf, cudf, pylibcudf, and test requirements" | ||||||||||||||
|
|
||||||||||||||
| # generate constraints (possibly pinning to oldest support versions of dependencies) | ||||||||||||||
| rapids-generate-pip-constraints py_test_dask_cudf ./constraints.txt | ||||||||||||||
| rapids-generate-pip-constraints py_test_dask_cudf "${PIP_CONSTRAINT}" | ||||||||||||||
|
|
||||||||||||||
| # notes: | ||||||||||||||
| # | ||||||||||||||
| # * echo to expand wildcard before adding `[test]` requires for pip | ||||||||||||||
| # * need to provide --constraint="${PIP_CONSTRAINT}" because that environment variable is | ||||||||||||||
| # ignored if any other --constraint are passed via the CLI | ||||||||||||||
| # * just providing --constraint="${PIP_CONSTRAINT}" to be explicit, and because | ||||||||||||||
| # that environment variable is ignored if any other --constraint are passed via the CLI | ||||||||||||||
| # | ||||||||||||||
| rapids-pip-retry install \ | ||||||||||||||
| -v \ | ||||||||||||||
| --constraint ./constraints.txt \ | ||||||||||||||
| --constraint "${PIP_CONSTRAINT}" \ | ||||||||||||||
| "$(echo "${CUDF_WHEELHOUSE}"/cudf_"${RAPIDS_PY_CUDA_SUFFIX}"*.whl)" \ | ||||||||||||||
| "$(echo "${DASK_CUDF_WHEELHOUSE}"/dask_cudf_"${RAPIDS_PY_CUDA_SUFFIX}"*.whl)[test]" \ | ||||||||||||||
|
|
||||||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.