Update mypy # type: ignore comments according to stricter mypy configs#20272
Merged
rapids-bot[bot] merged 9 commits intorapidsai:mainfrom Oct 23, 2025
Merged
Update mypy # type: ignore comments according to stricter mypy configs#20272rapids-bot[bot] merged 9 commits intorapidsai:mainfrom
# type: ignore comments according to stricter mypy configs#20272rapids-bot[bot] merged 9 commits intorapidsai:mainfrom
Conversation
mroeschke
added
the
improvement
github-actions
Bot
added
cudf.pandas
mroeschke
changed the title
# type: ignore comments according to stricter mypy configs
3 tasks
Matt711
approved these changes
Oct 22, 2025
bdice
approved these changes
Oct 22, 2025
Contributor
bdice
left a comment
bdice
left a comment
There was a problem hiding this comment.
Approving packaging changes.
galipremsagar
approved these changes
Oct 23, 2025
Contributor
Author
|
/merge |
3 tasks
rapids-bot Bot
pushed a commit
that referenced
this pull request
Nov 12, 2025
#19072 made a lot of the necessary fixes, but polars was not actually added to the pre-commit mypy environment so we haven't been checking since then. As a result, some new issues have crept in, and #20272 removed various ignores that are required for polars type safety but mypy didn't know that without polars available. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - Bradley Dice (https://github.com/bdice) - Tom Augspurger (https://github.com/TomAugspurger) - Matthew Murray (https://github.com/Matt711) URL: #20563
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enables the mypy rules
enable_error_code: ignore-without-codewarn_unused_ignores = trueTo remove or update our current
# type: ignorecomments with stricter mypy configurationsChecklist