Improve support for sliced input on from_arrow_host APIs#19491
Merged
rapids-bot[bot] merged 29 commits intorapidsai:branch-25.10from Aug 27, 2025
Merged
Improve support for sliced input on from_arrow_host APIs#19491rapids-bot[bot] merged 29 commits intorapidsai:branch-25.10from
rapids-bot[bot] merged 29 commits intorapidsai:branch-25.10from
Conversation
davidwendt
added
2 - In Progress
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Matt711
reviewed
Jul 30, 2025
Contributor
Matt711
left a comment
Matt711
left a comment
There was a problem hiding this comment.
If you remove this test: https://github.com/rapidsai/cudf/blob/67dae5d252e37f689a8a4e9506ec25db39d3b410/python/cudf_polars/cudf_polars/testing/plugin.py#L179C1-L179C21 from the list of exepected failures, then the cudf polars job should pass.
Matt711
reviewed
Jul 30, 2025
Contributor
Matt711
left a comment
Matt711
left a comment
There was a problem hiding this comment.
For the failing pandas-tests CI job, can you pull in the latest changes from 25.10? So we can see what tests are failing today.
github-actions
bot
added
Python
Contributor
Author
|
/ok to test |
wence-
reviewed
Aug 8, 2025
wence-
approved these changes
Aug 18, 2025
mythrocks
reviewed
Aug 22, 2025
mythrocks
reviewed
Aug 22, 2025
|
|
||
| template <typename T, CUDF_ENABLE_IF(not is_rep_layout_compatible<T>() && !is_fixed_point<T>())> | ||
| std::unique_ptr<column> operator()(ArrowSchemaView*, ArrowArray const*, data_type, bool) | ||
| std::unique_ptr<column> operator()(ArrowSchemaView const*, ArrowArray const*, data_type, bool) |
mythrocks
reviewed
Aug 22, 2025
mythrocks
approved these changes
Aug 25, 2025
Contributor
Author
|
/merge |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves support accepting ArrowArray sliced input where the range is beyond the 2 billion row limit.
The length (number of rows) of the sliced input must still be less than 2 billion but the offset/length range may reference indices above 2 billion.
Checklist