Build and ship shim.cu file as LTOIR#19368
Build and ship shim.cu file as LTOIR#19368rapids-bot[bot] merged 2 commits intorapidsai:branch-25.08from
shim.cu file as LTOIR#19368Conversation
|
A thought on naming for a future PR: do we want to rename "shim" to something like "fragment"? A shim sounds like it acts between two libraries to normalize API differences. In my understanding we're providing cuDF-friendly building blocks for Numba kernels to use, which feels more like a fragment ... or a library of device functions? |
|
@brandon-b-miller I'd like to see some kind of performance assessment here before merging but I don't want to block work on #18453. I'm okay with doing that assessment post-merge if you and @vyasr agree to it. |
|
@bdice that seems reasonable to me. While technically independent, It probably would be more meaningful to benchmark the strings kernels after both this PR and the NRT PR are merged, as the NRT PR's incref's and decrefs might add a lot to the delta between LTOIR on/off. I'm happy to take that on. I'd imagine stuffing a UDF full of a bunch of chained operators might be a good place to start. |
Originally when this file was conceived, it really was just an interop layer between libraries - it mostly forwarded function calls from the numba ABI to methods of |
|
/merge |
Closes #19362