Fix errors in the nvCOMP adapter#19221
Fix errors in the nvCOMP adapter#19221rapids-bot[bot] merged 15 commits intorapidsai:branch-25.08from
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
cpp/src/io/comp/nvcomp_adapter.cpp
Outdated
| capped_uncomp_bytes, nvcompBatchedSnappyCompressDefaultOpts, &max_comp_chunk_size); | ||
| break; | ||
| case compression_type::DEFLATE: | ||
| case compression_type::GZIP: // HACK! |
There was a problem hiding this comment.
It looks like we use deflate for GZIP. Can we write a more descriptive comment than “HACK”? Why was this done? Is there a TODO component? A missing API? An unsupported feature? A bug workaround?
There was a problem hiding this comment.
that comment (HACK) is a bit harsh :D
I can definitely replace with a better comment
There was a problem hiding this comment.
Actually, these should not yield the same result, so the HACK comment is on point.
Corrected the implementation.
| status = nvcompBatchedSnappyCompressGetMaxOutputChunkSize( | ||
| capped_uncomp_bytes, nvcompBatchedSnappyCompressDefaultOpts, &max_comp_chunk_size); | ||
| break; | ||
| case compression_type::DEFLATE: |
There was a problem hiding this comment.
| case compression_type::DEFLATE: | |
| case compression_type::DEFLATE: [[fallthrough]]; |
The fallthrough attribute helps tell the compiler and linters that this was intentional.
There was a problem hiding this comment.
We should not use [[fallthrough]] here. The code guidelines only recommend its use for non-empty fall-through cases. I think that compiler also only warns in this case as well.
|
/ok to test 9e2cf07 |
|
/merge |
rapids-bot
bot
merged commit 9563317
into
rapidsai:branch-25.08
Fix errors related to API changes (originally made in rapidsai#18931). Authors: - Vukasin Milovanovic (https://github.com/vuule) Approvers: - Bradley Dice (https://github.com/bdice) - Muhammad Haseeb (https://github.com/mhaseeb123) - https://github.com/nvdbaranec URL: rapidsai#19221
5 participants
Description
Fix errors related to API changes (originally made in #18931).
Checklist