Add C++ tests for different compression implementations#18690
Merged
rapids-bot[bot] merged 21 commits intorapidsai:branch-25.06from May 8, 2025
Merged
Add C++ tests for different compression implementations#18690rapids-bot[bot] merged 21 commits intorapidsai:branch-25.06from
rapids-bot[bot] merged 21 commits intorapidsai:branch-25.06from
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
vuule
added
tests
vuule
commented
May 6, 2025
| util::round_up_unsafe(page_g.max_hdr_size + page_g.max_data_size, page_align); | ||
| if (not comp_page_sizes.empty()) { | ||
| comp_page_offset += page_g.max_hdr_size + comp_page_sizes[ck_g.first_page]; | ||
| page_g.comp_data_size = comp_page_sizes[ck_g.first_page + num_pages]; |
Contributor
Author
There was a problem hiding this comment.
missed this one in #18644, because the test did not cover dictionary pages.
vuule
commented
May 6, 2025
Comment on lines
+1391
to
+1395
| // Generate compressible data | ||
| auto int_sequence = | ||
| cudf::detail::make_counting_transform_iterator(0, [](auto i) { return i % 100; }); | ||
| auto float_sequence = | ||
| cudf::detail::make_counting_transform_iterator(0, [](auto i) { return i / 32; }); |
Contributor
Author
There was a problem hiding this comment.
using this instead of create_compressible_fixed_table to ensure dict encoding is used
davidwendt
approved these changes
May 7, 2025
mythrocks
reviewed
May 7, 2025
Contributor
mythrocks
left a comment
mythrocks
left a comment
There was a problem hiding this comment.
Only a couple of clarifying questions. Almost done.
vuule
commented
May 7, 2025
Comment on lines
+39
to
+42
| tmp_env_var(tmp_env_var const&) = delete; | ||
| tmp_env_var& operator=(tmp_env_var const&) = delete; | ||
| tmp_env_var(tmp_env_var&&) = delete; | ||
| tmp_env_var& operator=(tmp_env_var&&) = delete; |
Contributor
Author
There was a problem hiding this comment.
Deleted these to remove the sharp edges, like having a vector of tmp_env_var that gets resized.
If we need to copy or move these eventually, we can implement these properly.
mythrocks
approved these changes
May 7, 2025
vuule
changed the title
3 tasks
Contributor
Author
|
/merge |
Contributor
Author
|
issue #18445 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add tests that are parameterized on the compression codec and the implementation (nvCOMP, internal kernel, host) to ensure all available implementations are tested for all supported codecs.
More tests will be added as issues with non-nvCOMP implementations are fixed.
Also: tests uncovered another bug in the Parquet writer; fixed it in this PR.
Checklist