-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Support multi-partition Select operations with aggregations
#18492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rapids-bot
merged 20 commits into
rapidsai:branch-25.06
from
rjzamora:complex-aggregations-ir
Apr 29, 2025
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
72017e0
Refactored Select decomposition - IR rewrites only - No new task-grap…
rjzamora a3494b7
Merge branch 'branch-25.06' into complex-aggregations-ir
rjzamora b4d4507
Merge remote-tracking branch 'upstream/branch-25.06' into complex-agg…
rjzamora 657ebae
improve coverage
rjzamora 121ec5f
Merge branch 'branch-25.06' into complex-aggregations-ir
rjzamora e7ed92a
Merge remote-tracking branch 'upstream/branch-25.06' into complex-agg…
rjzamora 0238052
Merge branch 'branch-25.06' into complex-aggregations-ir
rjzamora 0c26572
Merge branch 'branch-25.06' into complex-aggregations-ir
rjzamora 51eb142
Merge remote-tracking branch 'upstream/branch-25.06' into complex-agg…
rjzamora 69e6168
address partial code review
rjzamora 2ed1e26
remove _maybe_shuffle and refactor _decompose_expr_node
rjzamora 7f25e4b
fix unique_input_irs
rjzamora 77b372f
tweak comments
rjzamora 9764a65
remove comment
rjzamora 69642c1
Merge remote-tracking branch 'upstream/branch-25.06' into complex-agg…
rjzamora 02343a3
Merge branch 'branch-25.06' into complex-aggregations-ir
rjzamora 36c8551
Merge remote-tracking branch 'upstream/branch-25.06' into complex-agg…
rjzamora ffa5964
Merge remote-tracking branch 'upstream/branch-25.06' into complex-agg…
rjzamora 45ab83b
high-level notes
rjzamora a6e8ea6
Merge branch 'branch-25.06' into complex-aggregations-ir
rjzamora File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file comes from #18369 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| """DSL utilities.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| __all__: list[str] = [] |
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file comes from #18369 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025, NVIDIA CORPORATION & AFFILIATES. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| """Name generation utilities.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from typing import TYPE_CHECKING | ||
|
|
||
| if TYPE_CHECKING: | ||
| from collections.abc import Generator, Iterable | ||
|
|
||
|
|
||
| __all__ = ["unique_names"] | ||
|
|
||
|
|
||
| def unique_names(names: Iterable[str]) -> Generator[str, None, None]: | ||
| """ | ||
| Generate unique names relative to some known names. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| names | ||
| Names we should be unique with respect to. | ||
|
|
||
| Yields | ||
| ------ | ||
| Unique names (just using sequence numbers) | ||
| """ | ||
| prefix = "_" * max(map(len, names)) | ||
| i = 0 | ||
| while True: | ||
| yield f"{prefix}{i}" | ||
| i += 1 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.