-
Notifications
You must be signed in to change notification settings - Fork 1k
Manage strings with NRT #18453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rapids-bot
merged 62 commits into
rapidsai:branch-25.08
from
brandon-b-miller:link-to-memsys
Jul 23, 2025
Merged
Manage strings with NRT #18453
Changes from all commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
2456430
partial
brandon-b-miller c7a6f49
pass but not free
brandon-b-miller b23fae0
passing compute sanitizer, but not leak check
brandon-b-miller c2b8c79
Merge branch 'branch-25.04' into link-to-memsys
brandon-b-miller 1b044e3
pass leakcheck in string udf tests
brandon-b-miller 222ed5b
style
brandon-b-miller effa1b7
Merge branch 'branch-25.04' into link-to-memsys
brandon-b-miller fac219b
Merge branch 'branch-25.06' into link-to-memsys
brandon-b-miller 97bb510
remove nrt kwarg
brandon-b-miller 5efc8b3
Merge branch 'branch-25.06' into link-to-memsys
brandon-b-miller 1268348
Merge branch 'branch-25.06' into link-to-memsys
brandon-b-miller 7baa7b9
mege/resolve/pass
brandon-b-miller e8ca698
Merge branch 'branch-25.06' into link-to-memsys
brandon-b-miller 8aeb568
depend on numba-cuda to build python (probably too broad but can test…
brandon-b-miller 0c33b84
style
brandon-b-miller 1a44559
Merge branch 'branch-25.06' into link-to-memsys
bdice d4e370e
Merge branch 'branch-25.06' into link-to-memsys
brandon-b-miller 225e029
remove numba-cuda from build python common
brandon-b-miller 153976d
add build_python_cudf
brandon-b-miller 95d4719
Merge branch 'branch-25.06' into link-to-memsys
brandon-b-miller d1ed645
incref scalars too
brandon-b-miller dd9f5ef
Merge branch 'branch-25.06' into link-to-memsys
brandon-b-miller bc49992
Merge branch 'branch-25.06' into link-to-memsys
brandon-b-miller da8a8b2
remove extern_NRT_decref
brandon-b-miller 3df2720
merge/resolve/pass
brandon-b-miller 6c47e9c
merge/resolve
brandon-b-miller d1c760f
moved some cpp around
brandon-b-miller 4ce2b3e
cache freeing kernel
brandon-b-miller d6d853c
merge/resolve
brandon-b-miller 2692d64
runtime -> memory_management
brandon-b-miller 3e97547
cleanups
brandon-b-miller 72b432d
latest numba-cuda
brandon-b-miller f66f20a
more cleanup
brandon-b-miller 454e453
style
brandon-b-miller 56c1ebc
add numba-cuda to host section
brandon-b-miller 779d6e1
Merge branch 'branch-25.08' into link-to-memsys
brandon-b-miller 80dcf2e
xfail identity test
brandon-b-miller 9ce45c2
Merge branch 'branch-25.08' into link-to-memsys
vyasr 916f6f7
Merge branch 'branch-25.08' into link-to-memsys
brandon-b-miller a506f24
update deps
brandon-b-miller 7786905
Merge remote-tracking branch 'upstream/branch-25.08' into link-to-memsys
bdice 8e216d6
fix casting logic
brandon-b-miller 4903085
Unify meminfo creation with shim functions
brandon-b-miller ed26ef8
remove remaining usages of finalize
brandon-b-miller 94fa970
merge/resolve
brandon-b-miller 242e666
fix replace
brandon-b-miller 44eab7b
adjust make_meminfo_for_new_udf_string signature
brandon-b-miller df28f9b
partially address reviews
brandon-b-miller f1f3ae0
Apply suggestions from code review
brandon-b-miller 30d11d3
do not discard the result of placement new
brandon-b-miller 9632787
Merge branch 'branch-25.08' into link-to-memsys
galipremsagar 2c66dc5
merge/resolve/fix
brandon-b-miller 27ee8de
Merge branch 'branch-25.08' into link-to-memsys
bdice c3a20e8
merge/resolve/segfault
brandon-b-miller 0347754
merge/resolve
brandon-b-miller dec768d
remove dead cmake code
brandon-b-miller 37f3984
merge/resolve
brandon-b-miller 031b1da
docs, stats tests
brandon-b-miller e41a905
streamline, cleanup
brandon-b-miller 4ca6ec3
Merge branch 'branch-25.08' into link-to-memsys
brandon-b-miller b73291c
Apply suggestions from code review
brandon-b-miller 847fb6e
mostly address reviews
brandon-b-miller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,4 +27,5 @@ testing | |
| benchmarking | ||
| options | ||
| cudf_pandas | ||
| udf_memory_management | ||
| ``` | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.