Simplify trailing return types in AST operators. #18185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
improvement
davidwendt
approved these changes
Mar 6, 2025
miscco
reviewed
Mar 6, 2025
Comment on lines
765
to
769
| template <typename InputT> | ||
| __device__ inline auto operator()(InputT input) -> decltype(!input) | ||
| __device__ inline auto operator()(InputT input) -> bool | ||
| { | ||
| return !input; | ||
| } |
Comment on lines
+775
to
784
| template <typename From> | ||
| __device__ inline auto operator()(From f) -> To | ||
| { | ||
| if constexpr (cuda::std::is_floating_point_v<To>) { | ||
| if constexpr (is_fixed_point<From> && cuda::std::is_floating_point_v<To>) { | ||
| return convert_fixed_to_floating<To>(f); | ||
| } else { | ||
| return static_cast<To>(f); | ||
| } | ||
| } | ||
|
|
||
| template <typename From, typename cuda::std::enable_if_t<!is_fixed_point<From>()>* = nullptr> | ||
| __device__ inline auto operator()(From f) -> decltype(static_cast<To>(f)) | ||
| { | ||
| return static_cast<To>(f); | ||
| } | ||
| }; |
mhaseeb123
approved these changes
Mar 6, 2025
|
I’m seeing compilation errors for a bunch of these, including |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently AST operators use
decltypeaggressively to determine their trailing return types.In #17793 we found that CUDA 11 didn't work well with one such
decltypetrailing return type definition, resulting in a bug (root cause unknown).This PR simplifies our definitions of trailing return types when the output type is known and does not depend on the input type.
We assume that comparison and logical operators (
==,!=,<,>,<=,>=,&&,||,!) are always acting on regular-enough types to givebool, as expected by the C++ standard when those operators are not overloaded by the user.Checklist