Add Column.serialize to cudf-polars#17990
Merged
rapids-bot[bot] merged 6 commits intorapidsai:branch-25.04from Feb 13, 2025
Merged
Add Column.serialize to cudf-polars#17990rapids-bot[bot] merged 6 commits intorapidsai:branch-25.04from
Column.serialize to cudf-polars#17990rapids-bot[bot] merged 6 commits intorapidsai:branch-25.04from
Conversation
rjzamora
added
feature request
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
rjzamora
commented
Feb 12, 2025
rjzamora
commented
Feb 12, 2025
Member
Author
|
cc @TomAugspurger (In case you are interested/available) :) |
Matt711
approved these changes
Feb 12, 2025
Contributor
Matt711
left a comment
Matt711
left a comment
There was a problem hiding this comment.
This looks good to me, I think CI failures are unrelated
wence-
approved these changes
Feb 12, 2025
Contributor
TomAugspurger
left a comment
TomAugspurger
left a comment
There was a problem hiding this comment.
This looks nice overall. One question about typing.
rjzamora
added
5 - Ready to Merge
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It will be useful to serialize individual columns during multi-GPU cudf-polars execution. For example, the
Expr-decomposition approach proposed in #17941 may "require"Columnserialization (or an ugly workaround).Checklist