Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cudf::type_to_id<T const>() #17831

Open
wants to merge 3 commits into
base: branch-25.02
Choose a base branch
from

Conversation

esoha-nvidia
Copy link
Contributor

Description

Currently, cudf::type_to_id<X> where X is a valid type for converting to a cudf::id only works if X is neither const nor volatile. However, if it has either of those "cv" qualifiers, the function returns type_id::EMPTY.

With this change, return the correct type id no matter the cv-qualifiers.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@esoha-nvidia esoha-nvidia requested a review from a team as a code owner January 27, 2025 17:47
@esoha-nvidia esoha-nvidia requested review from bdice and shrshi January 27, 2025 17:47
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jan 27, 2025
Copy link

copy-pr-bot bot commented Jan 27, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 27, 2025
@davidwendt
Copy link
Contributor

/ok to test

Currently, `cudf::type_to_id<X>` where X is a valid type for converting to a `cudf::id` only works if X is neither `const` nor `volatile`.  However, if it has either of those "cv" qualifiers, the function returns `type_id::EMPTY`.

With this change, return the correct type id no matter the cv-qualifiers.
@esoha-nvidia
Copy link
Contributor Author

Please wait for CI to pass before merging this! I didn't check it much!

@davidwendt
Copy link
Contributor

/ok to test

@davidwendt
Copy link
Contributor

/ok to test

@davidwendt
Copy link
Contributor

Looks like many compile failures here. Example: https://github.com/rapidsai/cudf/actions/runs/12996716950/job/36246264687?pr=17831#step:8:3511
Looks to be centered on __int128_t but there may be others.
Since branch-25.02 is in burndown I would suggest moving this to 25.04 to give us more time to investigate a viable solution.

@karthikeyann
Copy link
Contributor

Looks like many compile failures here. Example: https://github.com/rapidsai/cudf/actions/runs/12996716950/job/36246264687?pr=17831#step:8:3511 Looks to be centered on __int128_t but there may be others. Since branch-25.02 is in burndown I would suggest moving this to 25.04 to give us more time to investigate a viable solution.

Move type_id_matches_device_storage_type definition below line 221.

@karthikeyann
Copy link
Contributor

/ok to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants