-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow cudf::type_to_id<T const>() #17831
base: branch-25.02
Are you sure you want to change the base?
Conversation
/ok to test |
Currently, `cudf::type_to_id<X>` where X is a valid type for converting to a `cudf::id` only works if X is neither `const` nor `volatile`. However, if it has either of those "cv" qualifiers, the function returns `type_id::EMPTY`. With this change, return the correct type id no matter the cv-qualifiers.
Please wait for CI to pass before merging this! I didn't check it much! |
/ok to test |
/ok to test |
Looks like many compile failures here. Example: https://github.com/rapidsai/cudf/actions/runs/12996716950/job/36246264687?pr=17831#step:8:3511 |
Move |
/ok to test |
Description
Currently,
cudf::type_to_id<X>
where X is a valid type for converting to acudf::id
only works if X is neitherconst
norvolatile
. However, if it has either of those "cv" qualifiers, the function returnstype_id::EMPTY
.With this change, return the correct type id no matter the cv-qualifiers.
Checklist