Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shellcheck to pre-commit and fix warnings #17778

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

gforsyth
Copy link
Contributor

Description

shellcheck is a fast, static analysis tool for shell scripts. It's good at
flagging up unused variables, unintentional glob expansions, and other potential
execution and security headaches that arise from the wonders of bash (and
other shlangs).

This PR adds a pre-commit hook to run shellcheck on all of the sh-lang
files in the ci/ directory, and the changes requested by shellcheck to make
the existing files pass the check.

xref: rapidsai/build-planning#135

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@gforsyth gforsyth added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 22, 2025
@gforsyth gforsyth requested a review from a team as a code owner January 22, 2025 16:32
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

ci/utils/nbtest.sh Show resolved Hide resolved
@galipremsagar
Copy link
Contributor

@gforsyth I cancelled the most recent workflow to free up resources to unblock all of cudf CI for this PR: #17771

I'll rerun once #17771 is merged.

@gforsyth
Copy link
Contributor Author

Thanks @galipremsagar -- I'll probably want to rebase on that PR anyway, so that I pick up the polars updates. I'll push that up once CI is a bit less jammed

@gforsyth
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 3d0725b into rapidsai:branch-25.02 Jan 29, 2025
106 checks passed
@gforsyth gforsyth deleted the shellcheck branch January 29, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants