Use the aligned_resource_adaptor to allocate bloom filter device buffers#17758
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
aligned_resource_adaptor to allocate bloom filter device buffers
aligned_resource_adaptor to allocate bloom filter device buffersaligned_resource_adaptor to allocate bloom filter device buffers
bdice
left a comment
There was a problem hiding this comment.
Looks good to me. It surprises me that this segfaulted the compiler in certain cases. We will need to file an internal bug report for this.
This PR doesn't unfortunately fix the compiler segfault unfortunately, (NVIDIA/cuCollections#660) should do that instead. I will update this PR to use the new |
aligned_resource_adaptor to allocate bloom filter device buffersaligned_resource_adaptor to allocate bloom filter device buffers
|
Locally verified with test data that the bloom filter is working as expected |
PointKernel
left a comment
There was a problem hiding this comment.
I tested locally with the 12.0 pip unified container and the compilation finished without issues.
@mhaseeb123 great work! And thank you, @sleeepyjack for the prompt fix on the cuco end.
|
/merge |
Description
Related to #17164
Related to NVIDIA/cuCollections#660
This PR creates and uses a
rmm::mr::aligned_resource_adapterto allocate device buffers for bloom filter data in accordance with bloom filter alignment requirements. This PR also updates thequery_bloom_filterfunction to use the newbloom_filter_refconstructors introduced in NVIDIA/cuCollections#660.Checklist