Fix the GDS read/write segfault/bus error when the cuFile policy is set to GDS or ALWAYS #17122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingcrimsontianyu
added
non-breaking
kingcrimsontianyu
changed the title
kingcrimsontianyu
changed the title
ttnghia
approved these changes
Oct 18, 2024
bdice
approved these changes
Oct 18, 2024
vuule
reviewed
Oct 18, 2024
| @@ -239,7 +239,7 @@ std::vector<std::future<ResultT>> make_sliced_tasks( | |||
| std::vector<std::future<ResultT>> slice_tasks; | |||
| std::transform(slices.cbegin(), slices.cend(), std::back_inserter(slice_tasks), [&](auto& slice) { | |||
| return pool.submit_task( | |||
| [&] { return function(ptr + slice.offset, slice.size, offset + slice.offset); }); | |||
| [=] { return function(ptr + slice.offset, slice.size, offset + slice.offset); }); | |||
There was a problem hiding this comment.
I don't understand how this worked for as long as it did.
There was a problem hiding this comment.
It is similar to the bug that I recently fixed for ORC reader, when reading file using the default stream 0. It's never showed up until recently.
kingcrimsontianyu
changed the title
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
LIBCUDF_CUFILE_POLICYis set toGDSorALWAYS, cuDF uses an internal implementation to call the cuFile API and harness the GDS feature. Recent tests with these two settings were unsuccessful due to program crash. Specifically, for thePARQUET_READER_NVBENCH'sparquet_read_io_compressionbenchmark:The root cause is the use of dangling reference, which occurs when a variable is captured by reference by nested lambdas. This PR performs a hotfix that turns out to be a 1-char change.
Checklist