-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug fix: use self.ck_consumer
in poll
method of kafka.py to align with __init__
#17044
bug fix: use self.ck_consumer
in poll
method of kafka.py to align with __init__
#17044
Conversation
Thanks for this contribution. Unfortunately, something seems to have gone wrong with the merges in your branch. I think it's only a one-line change? Perhaps you can cherry pick it onto the tip of branch-24.12 and then force push |
self.ck_consumer
in poll
method of kafka.py to align with __init__
self.ck_consumer
in poll
method of kafka.py to align with __init__
I apologize for cluttering the pull request. |
/ok to test |
@a-hirota please install pre-commit and run |
I have executed the instructed script, and the copyright has been updated as follows. Does this look good now?
|
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@a-hirota I've force-pushed to your branch removing all of the extraneous commits that were added here, hope you don't mind. The commit list is now just the two commits that you authored. |
/ok to test |
/merge |
Description
Updated the
poll
method inkafka.py
to useself.ck_consumer.poll(timeout)
instead ofself.ck.poll(timeout)
. This change ensures consistency with the__init__
method whereself.ck_consumer
is initialized.Checklist