Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix host_span constructor to correctly copy is_device_accessible #17020

Merged

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Oct 8, 2024

Description

One of the host_span constructors was not updated when we added is_device_accessible, so the value was not assigned.
This PR fixes this simple error and adds tests that checks that this property is correctly set when creating host_spans.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Oct 8, 2024
@vuule vuule added bug Something isn't working non-breaking Non-breaking change labels Oct 8, 2024
@vuule vuule self-assigned this Oct 8, 2024
@vuule vuule marked this pull request as ready for review October 9, 2024 00:53
@vuule vuule requested a review from a team as a code owner October 9, 2024 00:53
@vuule vuule requested review from zpuller and mhaseeb123 October 9, 2024 00:53
@vuule
Copy link
Contributor Author

vuule commented Oct 9, 2024

/merge

@rapids-bot rapids-bot bot merged commit c7b5119 into rapidsai:branch-24.12 Oct 9, 2024
122 checks passed
@vuule vuule deleted the guf-host_span-ctor-device-accesible branch December 10, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants