-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace old host tree algorithm with new algorithm in JSON reader #17019
Merged
rapids-bot
merged 3 commits into
rapidsai:branch-24.12
from
karthikeyann:enh-json_code_reorg2
Oct 19, 2024
Merged
Replace old host tree algorithm with new algorithm in JSON reader #17019
rapids-bot
merged 3 commits into
rapidsai:branch-24.12
from
karthikeyann:enh-json_code_reorg2
Oct 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrshi
approved these changes
Oct 10, 2024
what is the performance impact of the switch? |
Benchmark comparison:
branch-24.12 vs this PRjson_read_io[0] NVIDIA RTX 5880 Ada Generation
nested_json_gpu_parser_depth[0] NVIDIA RTX 5880 Ada Generation
json_reader[0] NVIDIA RTX 5880 Ada Generation
@vuule Performance impact is minimal. Slightly faster on smaller size jsons. |
vuule
approved these changes
Oct 18, 2024
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
cuIO
cuIO issue
improvement
Improvement / enhancement to an existing function
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaced old tree algorithm in JSON reader, with experimental algorithms and removed the experimental namespace.
Changes are old tree algorithm code removal, experimental namespace removal, code of
scatter_offsets
moved, always call new tree algorithm.No functional change is made in this PR. All unit tests should pass with this change.
Checklist