clang-tidy fixes part 3 #16939
Merged
clang-tidy fixes part 3 #16939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
improvement
davidwendt
reviewed
Sep 27, 2024
| int64_t shape[ndim] = {5}; | ||
| int64_t strides[ndim] = {0}; | ||
| int64_t shape[ndim] = {5}; // NOLINT | ||
| int64_t strides[ndim] = {0}; // NOLINT |
There was a problem hiding this comment.
It disables clang-tidy checks on this line. I used it for structs containing raw C-style arrays when the structs were either 1) implementing what seemed like a well-defined protocol or file format (for I/O) or 2) when the structs looked like they could be memcopied over to device.
davidwendt
approved these changes
Sep 27, 2024
|
/merge |
copy-pr-bot bot
pushed a commit
that referenced
this pull request
Sep 28, 2024
Subset of improvements to the code base proposed by the latest version of clang-tidy. **Note to reviewers**: The changeset looks deceptively large. Almost all of the change are really just switching from raw C-style arrays to C++ std::arrays. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - David Wendt (https://github.com/davidwendt) - Basit Ayantunde (https://github.com/lamarrr) URL: #16939
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Subset of improvements to the code base proposed by the latest version of clang-tidy.
Note to reviewers: The changeset looks deceptively large. Almost all of the change are really just switching from raw C-style arrays to C++ std::arrays.
Checklist