Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid public constructors when called with columns to avoid unnecessary validation #16747

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

mroeschke
Copy link
Contributor

Description

This PR continues an effort to avoid some public constructors when passing a column(s) to avoid unnecessary validation

Maybe we should consider disallowing public constructors to accept columns all-together, but I suspect some RAPIDS libraries are passing columns to public constructors

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 4, 2024
@mroeschke mroeschke requested a review from a team as a code owner September 4, 2024 20:40
@mroeschke mroeschke requested review from bdice and Matt711 September 4, 2024 20:40
@vyasr
Copy link
Contributor

vyasr commented Sep 4, 2024

I suspect some RAPIDS libraries are passing columns to public constructors

I'd be fine with disallowing it as long as we tested and updated downstream libraries for this beforehand. devcontainers would be a good way to do this.

@mroeschke mroeschke changed the base branch from branch-24.10 to branch-24.12 September 25, 2024 20:25
@vyasr
Copy link
Contributor

vyasr commented Sep 26, 2024

/merge

@rapids-bot rapids-bot bot merged commit 670cc3f into rapidsai:branch-24.12 Sep 27, 2024
96 checks passed
@mroeschke mroeschke deleted the ref/constructors branch September 27, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants