Accelerate stable-segmented-sort with CUB segmented sort#12347
Merged
rapids-bot[bot] merged 9 commits intorapidsai:branch-23.02from Dec 15, 2022
Merged
Accelerate stable-segmented-sort with CUB segmented sort#12347rapids-bot[bot] merged 9 commits intorapidsai:branch-23.02from
rapids-bot[bot] merged 9 commits intorapidsai:branch-23.02from
Conversation
davidwendt
added
2 - In Progress
davidwendt
commented
Dec 8, 2022
| namespace cudf { | ||
| namespace detail { | ||
|
|
||
| namespace { |
Contributor
Author
There was a problem hiding this comment.
This code moved to segmented_sort_impl.cuh
davidwendt
commented
Dec 8, 2022
| @@ -0,0 +1,324 @@ | |||
| /* | |||
Contributor
Author
There was a problem hiding this comment.
This code was moved from segmented_sort.cu and the calls to CUB's stable-segmented-sort functions are added.
Codecov ReportBase: 86.58% // Head: 85.76% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #12347 +/- ##
================================================
- Coverage 86.58% 85.76% -0.82%
================================================
Files 155 155
Lines 24368 24795 +427
================================================
+ Hits 21098 21266 +168
- Misses 3270 3529 +259
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
davidwendt
added
3 - Ready for Review
ttnghia
approved these changes
Dec 14, 2022
robertmaynard
approved these changes
Dec 14, 2022
Contributor
robertmaynard
left a comment
robertmaynard
left a comment
There was a problem hiding this comment.
CMake changes LGTM
PointKernel
reviewed
Dec 14, 2022
PointKernel
approved these changes
Dec 14, 2022
Contributor
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds calls to
cub::DeviceSegmentedSort::StableSortPairsforcudf::segmented_sorted_order.Refactors libcudf segmented-sort and stable-segmented-sort functions into separate source files and moves the common code into
segmented_sort_impl.cuh.Also adds gtests for
cudf::stable_segmented_sort.Reference #11729
Checklist