-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leverage rapids_cython for more automated RPATH handling #11996
Leverage rapids_cython for more automated RPATH handling #11996
Conversation
Codecov ReportBase: 87.40% // Head: 88.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #11996 +/- ##
================================================
+ Coverage 87.40% 88.11% +0.71%
================================================
Files 133 133
Lines 21833 22003 +170
================================================
+ Hits 19084 19389 +305
+ Misses 2749 2614 -135
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
a135765
to
aad1fa3
Compare
@gpucibot merge |
Description
This PR leverages a new feature of rapids-cmake to avoid needing to manually set the RPATHs for all extension modules individually, instead just pointing to a directory once and then letting rapids-cmake automatically handle the rest. This approach is a lot less error-prone since developers do not need to keep track of the relative paths in each CMakeLists.txt file.
Checklist