Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage rapids_cython for more automated RPATH handling #11996

Merged

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Oct 25, 2022

Description

This PR leverages a new feature of rapids-cmake to avoid needing to manually set the RPATHs for all extension modules individually, instead just pointing to a directory once and then letting rapids-cmake automatically handle the rest. This approach is a lot less error-prone since developers do not need to keep track of the relative paths in each CMakeLists.txt file.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 25, 2022
@vyasr vyasr self-assigned this Oct 25, 2022
@github-actions github-actions bot added the Python Affects Python cuDF API. label Oct 25, 2022
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 87.40% // Head: 88.11% // Increases project coverage by +0.71% 🎉

Coverage data is based on head (e1e6856) compared to base (f72c4ce).
Patch has no changes to coverable lines.

❗ Current head e1e6856 differs from pull request most recent head 0436cd5. Consider uploading reports for the commit 0436cd5 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11996      +/-   ##
================================================
+ Coverage         87.40%   88.11%   +0.71%     
================================================
  Files               133      133              
  Lines             21833    22003     +170     
================================================
+ Hits              19084    19389     +305     
+ Misses             2749     2614     -135     
Impacted Files Coverage Δ
python/strings_udf/strings_udf/__init__.py 84.31% <0.00%> (-12.57%) ⬇️
python/cudf/cudf/io/text.py 91.66% <0.00%> (-8.34%) ⬇️
python/cudf/cudf/core/_base_index.py 81.28% <0.00%> (-4.27%) ⬇️
python/cudf/cudf/io/json.py 92.06% <0.00%> (-2.68%) ⬇️
python/strings_udf/strings_udf/_typing.py 94.73% <0.00%> (-1.06%) ⬇️
python/cudf/cudf/utils/utils.py 89.91% <0.00%> (-0.69%) ⬇️
python/cudf/cudf/testing/dataset_generator.py 72.83% <0.00%> (-0.42%) ⬇️
python/dask_cudf/dask_cudf/core.py 73.72% <0.00%> (-0.41%) ⬇️
python/cudf/cudf/io/parquet.py 90.45% <0.00%> (-0.39%) ⬇️
python/dask_cudf/dask_cudf/backends.py 84.90% <0.00%> (-0.37%) ⬇️
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vyasr vyasr force-pushed the feature/rapids_cython_lib_dirs branch from a135765 to aad1fa3 Compare October 26, 2022 23:55
@vyasr vyasr marked this pull request as ready for review November 1, 2022 17:03
@vyasr vyasr requested a review from a team as a code owner November 1, 2022 17:03
@vyasr vyasr requested review from bdice, brandon-b-miller and a team November 1, 2022 17:03
@vyasr
Copy link
Contributor Author

vyasr commented Nov 1, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2fe06bc into rapidsai:branch-22.12 Nov 1, 2022
@vyasr vyasr deleted the feature/rapids_cython_lib_dirs branch November 1, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants