Skip to content

Struct support for NULL_EQUALS binary operation#11520

Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-22.10from
rwlee:rwlee/eqnullaware
Aug 15, 2022
Merged

Struct support for NULL_EQUALS binary operation#11520
rapids-bot[bot] merged 3 commits intorapidsai:branch-22.10from
rwlee:rwlee/eqnullaware

Conversation

@rwlee
Copy link
Contributor

@rwlee rwlee commented Aug 12, 2022

Description

Adds support for Spark's null aware equality binop and expands/improves Java testing for struct binops. Properly tests null structs and full operator testing coverage. Utilizes existing Spark struct binop support with JNI changes to force the full null-aware comparison.

Expands on #11153

Partial solution to #8964 -- NULL_MAX and NULL_MIN still outstanding.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rwlee rwlee added 3 - Ready for Review Ready for review by team Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 12, 2022
@rwlee rwlee requested review from a team as code owners August 12, 2022 01:42
@rwlee rwlee requested review from upsj and vuule August 12, 2022 01:42
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 12, 2022
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@0df6178). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.10   #11520   +/-   ##
===============================================
  Coverage                ?   86.36%           
===============================================
  Files                   ?      145           
  Lines                   ?    22945           
  Branches                ?        0           
===============================================
  Hits                    ?    19816           
  Misses                  ?     3129           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@upsj upsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ changes LGTM!

@rwlee
Copy link
Contributor Author

rwlee commented Aug 15, 2022

@gpucibot merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants