Skip to content

Take iterators by value in clamp.cu. #11084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rapids-bot merged 2 commits into from
Jun 16, 2022
Merged

Take iterators by value in clamp.cu. #11084

rapids-bot merged 2 commits into from
Jun 16, 2022

Conversation

@bdice
Copy link
Contributor

@bdice bdice commented Jun 8, 2022

This PR updates clamp.cu to take templated iterator types by value. This aligns the style with the rest of libcudf. See also: #11019 (comment)

@bdice bdice added code quality libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 8, 2022
@bdice bdice self-assigned this Jun 8, 2022
@bdice bdice requested a review from a team as a code owner June 8, 2022 19:00
@bdice bdice requested review from harrism and ttnghia June 8, 2022 19:00
@ajschmidt8
Copy link
Member

ajschmidt8 commented Jun 9, 2022

rerun tests

1 similar comment
@bdice
Copy link
Contributor Author

bdice commented Jun 13, 2022

rerun tests

@codecov
Copy link

codecov bot commented Jun 16, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@fff29be). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08   #11084   +/-   ##
===============================================
  Coverage                ?   86.34%           
===============================================
  Files                   ?      144           
  Lines                   ?    22741           
  Branches                ?        0           
===============================================
  Hits                    ?    19635           
  Misses                  ?     3106           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fff29be...4d42a55. Read the comment docs.

@vyasr
Copy link
Contributor

vyasr commented Jun 16, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0f77adc into rapidsai:branch-22.08 Jun 16, 2022
@bdice bdice mentioned this pull request Jul 8, 2022
Merged
@bdice bdice mentioned this pull request Aug 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harrism harrism harrism approved these changes

@ttnghia ttnghia ttnghia approved these changes

@davidwendt davidwendt davidwendt approved these changes

Assignees

@bdice bdice

Labels

improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bdice @ajschmidt8 @vyasr @harrism @ttnghia @davidwendt