[REVIEW] Add support for Series.between
#11051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
feature request
galipremsagar
added
non-breaking
bdice
requested changes
Jun 3, 2022
Contributor
bdice
left a comment
bdice
left a comment
There was a problem hiding this comment.
Please expand testing to validate more of the claimed behaviors of the docstring -- otherwise LGTM! Thank you for adding this feature so quickly to unblock downstream work. 😄
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #11051 +/- ##
===============================================
Coverage ? 86.34%
===============================================
Files ? 144
Lines ? 22723
Branches ? 0
===============================================
Hits ? 19620
Misses ? 3103
Partials ? 0 Continue to review full report at Codecov.
|
bdice
reviewed
Jun 4, 2022
bdice
approved these changes
Jun 6, 2022
Contributor
bdice
left a comment
bdice
left a comment
There was a problem hiding this comment.
The additional tests are a good touch. Nice work @galipremsagar.
galipremsagar
added
5 - Ready to Merge
Contributor
Author
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #10443
This PR adds
betweenAPI forSeries. Here is the reference pandas API: https://pandas.pydata.org/docs/reference/api/pandas.Series.between.html