-
Notifications
You must be signed in to change notification settings - Fork 1k
[REVIEW] Use ThreadedMotoServer instead of subprocess in spinning up s3 server
#10822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ThreadedMotoServer instead of subprocessThreadedMotoServer instead of subprocess in spinning up s3 server
bdice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion for cleaning up the import-or-skip behavior. Otherwise LGTM! Thanks for these improvements, @galipremsagar!
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10822 +/- ##
================================================
- Coverage 86.40% 86.31% -0.10%
================================================
Files 143 144 +1
Lines 22448 22640 +192
================================================
+ Hits 19396 19541 +145
- Misses 3052 3099 +47
Continue to review full report at Codecov.
|
|
@gpucibot merge |
This is a follow-up PR to address review comments from here: #10769 (review)
This PR:
ThreadedMotoServerinstead of usingsubprocess.opento create a new server, this way it is guaranteed to close the server upon exit.