Skip to content

Conversation

@PointKernel
Copy link
Member

@PointKernel PointKernel commented May 4, 2022

Closes #10572

This PR fetches the changes in NVIDIA/cuCollections#151 to avoid launching kernels with 0 threads.

@PointKernel PointKernel added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels May 4, 2022
@PointKernel PointKernel requested a review from a team as a code owner May 4, 2022 16:37
@PointKernel PointKernel self-assigned this May 4, 2022
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels May 4, 2022
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #10788 (e2688fb) into branch-22.06 (8d861ce) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head e2688fb differs from pull request most recent head b5a4730. Consider uploading reports for the commit b5a4730 to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06   #10788      +/-   ##
================================================
+ Coverage         86.40%   86.43%   +0.03%     
================================================
  Files               143      143              
  Lines             22448    22448              
================================================
+ Hits              19396    19403       +7     
+ Misses             3052     3045       -7     
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 93.74% <0.00%> (+0.04%) ⬆️
python/cudf/cudf/core/column/string.py 89.21% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.79% <0.00%> (+0.22%) ⬆️
python/cudf/cudf/core/column/numerical.py 96.17% <0.00%> (+0.29%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 92.91% <0.00%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d861ce...b5a4730. Read the comment docs.

@PointKernel
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d994905 into rapidsai:branch-22.06 May 5, 2022
@PointKernel PointKernel deleted the update-cuco-tag branch May 5, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] JoinTest.EmptyLeftTableFullJoin memory errors

2 participants