Fix error thrown in compiled-binaryop benchmark #10398
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
BINARYOP_BENCHwhich is throwing an error for non-numeric types:The
compiled_binaryop.cppwas recently changed in #10300 to create test columns using the benchmark utilitycreate_sequence_tablewhich internally callscudf::sequenceAPI. Unfortunately, onlynumerictypes can be used with this API which throws an error for types liketimestamp, duration, and decimalwhich are being measured in this file. https://docs.rapids.ai/api/libcudf/stable/group__transformation__fill.html#gaeda630c9dcdd152eeecf0a1b636244acThe fix replaces the
create_sequence_tablecall withcreate_random_tableto generate the source columns instead.