chan_vese: pass all constants to _fused_variance_kernel2 as device scalars
#764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* avoids an issue with an internal numpy.can_cast call in CuPy's kernel fusion code when using NumPy 2.0
grlee77
added
bug
jakirkham
reviewed
Aug 21, 2024
Co-authored-by: jakirkham <[email protected]>
jakirkham
approved these changes
Aug 21, 2024
|
Thanks @grlee77 It looks good to me! |
gigony
approved these changes
Aug 21, 2024
|
/merge |
|
Thanks Greg and Gigon! 🙏 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change avoids an issue with an internal
numpy.can_castcall in CuPy's kernel fusion code when using NumPy 2.0. With this change all cuCIM tests passed using NumPy 2.0.1 and the CuPy 13.3dev branch.Fixes #742