Skip to content

Conversation

@grlee77
Copy link
Contributor

@grlee77 grlee77 commented Feb 7, 2023

around and round are equivalent, but round is only present in CuPy>=11. Switch to around here for compatibility with CuPy 10.x releases.

cp.around is equivalent, but only present in CuPy>=11
@grlee77 grlee77 added bug Something isn't working non-breaking Introduces a non-breaking change labels Feb 7, 2023
@grlee77 grlee77 added this to the v23.04.00 milestone Feb 7, 2023
@grlee77 grlee77 requested a review from a team as a code owner February 7, 2023 21:02
@jakirkham jakirkham requested a review from bhashemian February 7, 2023 21:25
@jakirkham
Copy link
Member

cc @drbeh

Copy link
Member

@bhashemian bhashemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (branch-23.04@90d021e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...rc/cucim/core/operations/color/stain_normalizer.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.04     #508   +/-   ##
===============================================
  Coverage                ?   92.89%           
===============================================
  Files                   ?      131           
  Lines                   ?     9905           
  Branches                ?        0           
===============================================
  Hits                    ?     9201           
  Misses                  ?      704           
  Partials                ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jakirkham
Copy link
Member

@gpucibot merge

@rapids-bot
Copy link

rapids-bot bot commented Feb 7, 2023

@jakirkham, the @gpucibot merge command has been replaced with /merge.

Please re-comment this PR with /merge and use this new command in the future.

@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit e391989 into rapidsai:branch-23.04 Feb 7, 2023
@jakirkham
Copy link
Member

Thank you both! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants