-
Notifications
You must be signed in to change notification settings - Fork 70
use cp.around instead of cp.round for CuPy 10.x compatiblity #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use cp.around instead of cp.round for CuPy 10.x compatiblity #508
Conversation
cp.around is equivalent, but only present in CuPy>=11
|
cc @drbeh |
bhashemian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## branch-23.04 #508 +/- ##
===============================================
Coverage ? 92.89%
===============================================
Files ? 131
Lines ? 9905
Branches ? 0
===============================================
Hits ? 9201
Misses ? 704
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@gpucibot merge |
|
@jakirkham, the Please re-comment this PR with |
|
/merge |
|
Thank you both! 🙏 |
aroundandroundare equivalent, butroundis only present in CuPy>=11. Switch toaroundhere for compatibility with CuPy 10.x releases.