Skip to content

Conversation

@quasiben
Copy link
Member

PR Merges current 0.20 to 0.19

gigony and others added 9 commits April 13, 2021 14:11
This patch addresses rapidsai#2 

- Add GTC session and notebooks information to README.md
- Update Welcome notebook to include existing notebooks
- Remove `notebooks/Single-process_Tests.ipynb`
- Update existing notebooks, assuming that cuCIM is already installed

Authors:
  - Gigon Bae (https://github.com/gigony)
  - Benjamin Zaitlen (https://github.com/quasiben)

Approvers:
  - Benjamin Zaitlen (https://github.com/quasiben)

URL: rapidsai#4
Currently we support CUDA 11.0 and 11.2. Newer CUDA versions are not yet supported. Also CUDA 11.1 was skipped.

Authors:
  - https://github.com/jakirkham

Approvers:
  - Gigon Bae (https://github.com/gigony)
  - Ray Douglass (https://github.com/raydouglass)
  - Benjamin Zaitlen (https://github.com/quasiben)

URL: rapidsai#5
Fix a memory leak and update release notes for v0.19.0
@quasiben quasiben added breaking Introduces a breaking change doc Improvements or additions to documentation improvement Improves an existing functionality and removed doc Improvements or additions to documentation labels Apr 16, 2021
@jakirkham jakirkham requested a review from gigony April 16, 2021 15:35
@gigony
Copy link
Contributor

gigony commented Apr 16, 2021

Thanks @quasiben ! I had to add additional patches to make sure that local build with conda should work. (#12 )
Wonder if fast-forward branch-0.19 to branch-0.20 is possible once #12 is approved&merged.

- Update `run` script to download GDS from public package (cufile.h is needed to build it locally)
  - Update CMakeLists.txt accordingly
  - GDS is still disabled (need to use GDS Conda package and verify it before enabling GDS)
- Update CUDA EULA (which include libcufile)
- Add dependency to `yasm` which is needed for building libjpeg-turbo
- Clear CMakeCathe.txt and existing .so files to build with the updated options
- Minor code change (unnecessarily std::move which degrade performance).
- Add changelog for `v0.18.3` and update the release date of v0.19.0 to 4/19/2021

Verified with a fresh system that https://github.com/rapidsai/cucim/blob/branch-0.20/CONTRIBUTING.md#script-to-build-cucim-from-source is working. (Previously it didn't work due to `yasm` dependency).

Authors:
- Gigon Bae (https://github.com/gigony)
@quasiben
Copy link
Member Author

@gigony i merged in latest changes from branch-20 to here. Was that the last change needed before the release ?

@gigony
Copy link
Contributor

gigony commented Apr 19, 2021 via email

@raydouglass raydouglass merged commit bb843bf into rapidsai:branch-0.19 Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Introduces a breaking change improvement Improves an existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants