Skip to content
This repository was archived by the owner on May 19, 2023. It is now read-only.

Bump isort hook to 5.6.4, add non-conflicting profiles for isort/black - #445

Closed
charlesbluca wants to merge 3 commits into
rapidsai:branch-21.12from
charlesbluca:bump-isort
Closed

charlesbluca wants to merge 3 commits into
rapidsai:branch-21.12from
charlesbluca:bump-isort

Conversation

@charlesbluca

Copy link
Copy Markdown
Member

Bumps the isort pre-commit hook to 5.6.4 to correspond with the gpuCI version bump (see rapidsai/integration#286). Also adds profiles for isort and black so that they will not conflict.

@charlesbluca

Copy link
Copy Markdown
Member Author

I noticed that the gpuCI style script for this repo doesn't actually check isort or black - is that intended? If so, this PR might not be necessary unless we want this repo to have consistent styling with other RAPIDS projects. If it isn't, happy to open up a follow up PR adding those checks to the script.

@charlesbluca
charlesbluca changed the base branch from branch-21.08 to branch-21.10 July 22, 2021 13:55
@charlesbluca
charlesbluca changed the base branch from branch-21.10 to branch-21.12 September 24, 2021 00:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants