Skip to content
This repository was archived by the owner on May 19, 2023. It is now read-only.

[REVIEW] gpuCI Scripts Update - #276

Merged
rapids-bot[bot] merged 15 commits into
rapidsai:branch-0.18from
dillon-cullinan:enh-flash
Jan 15, 2021
Merged

rapids-bot[bot] merged 15 commits into
rapidsai:branch-0.18from
dillon-cullinan:enh-flash

Conversation

@dillon-cullinan

Copy link
Copy Markdown
Contributor

Overview
First step before "Project Flash" to improve gpuCI scripts and allow for use of different node types for CPU builds. Post "Project Flash" there will be another round of improvements and updates with the goal to make these scripts easier to maintain.

Changes

  • Consolidates some of the CPU gpuCI scripts, reducing number of scripts to maintain
  • Standardizes naming of the upload script to upload.sh
  • Changes logging to use gpuci_logger where practical
  • Updates comments and documentation where necessary
  • Enables gpuCI to override environment variables based on node types

@dillon-cullinan
dillon-cullinan requested a review from a team as a code owner October 26, 2020 15:15
@GPUtester

Copy link
Copy Markdown
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@mike-wendt mike-wendt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor fixes. Need to figure out why conda builds are erroring

Comment thread ci/cpu/upload.sh Outdated
Comment thread ci/gpu/build.sh
Comment thread ci/docs/build.sh Outdated
@dillon-cullinan
dillon-cullinan changed the base branch from branch-0.17 to branch-0.18 December 4, 2020 21:44
@dillon-cullinan dillon-cullinan added non-breaking Non-breaking change enhancement New feature or request labels Dec 14, 2020
@msadang msadang added gpuCI improvement Improvement / enhancement to an existing function labels Jan 11, 2021
@dillon-cullinan dillon-cullinan changed the title [REVIEW] Project Flash & gpuCI Scripts Update [REVIEW] gpuCI Scripts Update Jan 15, 2021
@rapids-bot
rapids-bot Bot merged commit 0ed2844 into rapidsai:branch-0.18 Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request gpuCI improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants