Skip to content

use bash arrays for package lists, other misc. maintenance#343

Merged
jameslamb merged 3 commits intorapidsai:mainfrom
jameslamb:misc-updates
Jan 8, 2026
Merged

use bash arrays for package lists, other misc. maintenance#343
jameslamb merged 3 commits intorapidsai:mainfrom
jameslamb:misc-updates

Conversation

@jameslamb
Copy link
Member

@jameslamb jameslamb commented Jan 7, 2026

Miscellaneous small cleanup and follow-ups.

Mount GH_TOKEN as environment variable secret

Follow-up from #336 (review)

Mounts the GitHub token used for gh cli calls as an environment variable secret, so commands don't need to cat it from the filesystem.

Adds floors on all conda and pip packages

I've added floors on every {conda,mamba,pip} install package in Dockerfiles here. Set them to the versions we're currently pulling in, which in all cases looked to me like the latest versions.

Benefits of doing this:

Switches package lists to bash arrays

Follow-up from #342 (comment)

This makes it easier to change the set of installed packages based on details like CUDA version, OS, etc. (example: #199)

Adds a .gitignore

This project should have a .gitignore to avoid checking in unwanted files. I've proposed one here that I use in other projects.

Docs updates

  • renamed section about building locally (you build "images" not "dockerfiles")
  • documents gha-tools requirement in docs on building locally (current instructions fail with rapids-version-major-minor: command not found)
  • changes formatting per https://yihui.org/en/2021/06/markdown-breath/

@jameslamb jameslamb changed the title WIP: use bash arrays for package lists, other misc. maintenance use bash arrays for package lists, other misc. maintenance Jan 7, 2026
@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jan 7, 2026
@jameslamb jameslamb marked this pull request as ready for review January 7, 2026 20:22
@jameslamb jameslamb requested a review from a team as a code owner January 7, 2026 20:22
@jameslamb jameslamb requested review from gforsyth and removed request for a team January 7, 2026 20:22
Copy link
Contributor

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, these all look like solid changes and the bash arrays will make additions less error-prone in the future.

@jameslamb
Copy link
Member Author

Thanks for the review!

@jameslamb jameslamb merged commit 0143b2b into rapidsai:main Jan 8, 2026
703 of 704 checks passed
@jameslamb jameslamb deleted the misc-updates branch January 8, 2026 15:24
rapids-bot bot pushed a commit to rapidsai/docker that referenced this pull request Jan 8, 2026
Contributes to #832 

Removes reliance on https://hub.docker.com/r/rapidsai/ci-conda in this repo. It was only being used in 2 places, both of which could be run in simpler environments:

* in a `compute-matrix` job that just needs `bash`, `jq` and `yq` --> regular old `ubuntu-latest` GitHub Actions VM is fine
* in a part of a multi-stage build that just needs `bash`, `git`, `pip`, and a Python interpreter --> `python:{version}` container is fine

Other changes based on PR reviewers:

* puts versions to be managed by renovate in a `versions.yaml` ([borrowing the approach from rapidsai/ci-imgs](https://github.com/rapidsai/ci-imgs/blob/28b8b5ac127bcf5cd6679cd8ee40a53ce7240421/ci/compute-build-args.sh#L36))
* updates shell code in Dockerfiles to match our preferred style (including the array format for package lists from rapidsai/ci-imgs#343)
* sets all empty arg defaults to `notset` (ref: #689 (comment))
  - *weakly prefer `notset`  to `unset` because `unset` is a valid shell command*
* alphabetizes build args in Dockerfiles

## Notes for Reviewers

### This is only the beginning

To be clear, this project still heavily relies on `rapidsai/miniforge-cuda` (the base image for `rapidsai/ci-conda`. So there's more work to do for #832.

But this at least means we no longer need to care about anything in these lines breaking the things in this repo 😁 :

https://github.com/rapidsai/ci-imgs/blob/55b24734b7d594e768599771dcae2e718af52f9a/ci-conda.Dockerfile#L183-L313

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #834
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants