use bash arrays for package lists, other misc. maintenance#343
Merged
jameslamb merged 3 commits intorapidsai:mainfrom Jan 8, 2026
Merged
use bash arrays for package lists, other misc. maintenance#343jameslamb merged 3 commits intorapidsai:mainfrom
jameslamb merged 3 commits intorapidsai:mainfrom
Conversation
gforsyth
approved these changes
Jan 8, 2026
Contributor
gforsyth
left a comment
There was a problem hiding this comment.
Yep, these all look like solid changes and the bash arrays will make additions less error-prone in the future.
Member
Author
|
Thanks for the review! |
rapids-bot bot
pushed a commit
to rapidsai/docker
that referenced
this pull request
Jan 8, 2026
Contributes to #832 Removes reliance on https://hub.docker.com/r/rapidsai/ci-conda in this repo. It was only being used in 2 places, both of which could be run in simpler environments: * in a `compute-matrix` job that just needs `bash`, `jq` and `yq` --> regular old `ubuntu-latest` GitHub Actions VM is fine * in a part of a multi-stage build that just needs `bash`, `git`, `pip`, and a Python interpreter --> `python:{version}` container is fine Other changes based on PR reviewers: * puts versions to be managed by renovate in a `versions.yaml` ([borrowing the approach from rapidsai/ci-imgs](https://github.com/rapidsai/ci-imgs/blob/28b8b5ac127bcf5cd6679cd8ee40a53ce7240421/ci/compute-build-args.sh#L36)) * updates shell code in Dockerfiles to match our preferred style (including the array format for package lists from rapidsai/ci-imgs#343) * sets all empty arg defaults to `notset` (ref: #689 (comment)) - *weakly prefer `notset` to `unset` because `unset` is a valid shell command* * alphabetizes build args in Dockerfiles ## Notes for Reviewers ### This is only the beginning To be clear, this project still heavily relies on `rapidsai/miniforge-cuda` (the base image for `rapidsai/ci-conda`. So there's more work to do for #832. But this at least means we no longer need to care about anything in these lines breaking the things in this repo 😁 : https://github.com/rapidsai/ci-imgs/blob/55b24734b7d594e768599771dcae2e718af52f9a/ci-conda.Dockerfile#L183-L313 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #834
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Miscellaneous small cleanup and follow-ups.
Mount
GH_TOKENas environment variable secretFollow-up from #336 (review)
Mounts the GitHub token used for
gh clicalls as an environment variable secret, so commands don't need tocatit from the filesystem.Adds floors on all
condaandpippackagesI've added floors on every
{conda,mamba,pip} installpackage in Dockerfiles here. Set them to the versions we're currently pulling in, which in all cases looked to me like the latest versions.Benefits of doing this:
Switches package lists to bash arrays
Follow-up from #342 (comment)
This makes it easier to change the set of installed packages based on details like CUDA version, OS, etc. (example: #199)
Adds a
.gitignoreThis project should have a
.gitignoreto avoid checking in unwanted files. I've proposed one here that I use in other projects.Docs updates
gha-toolsrequirement in docs on building locally (current instructions fail withrapids-version-major-minor: command not found)