ci-wheel: always use auditwheel packages with wildcard support#230
Merged
jameslamb merged 1 commit intorapidsai:mainfrom Jan 22, 2025
jameslamb:new-auditwheel
Merged
ci-wheel: always use auditwheel packages with wildcard support#230jameslamb merged 1 commit intorapidsai:mainfrom jameslamb:new-auditwheel
jameslamb merged 1 commit intorapidsai:mainfrom
jameslamb:new-auditwheel
Conversation
jameslamb
added
improvement
bdice
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#137
Starting with the work for that issue, we began relying on support for wildcards in
auditwheel repair --excludein wheel builds:That feature was first added to
auditwheel(by our own @KyleFromNVIDIA !) in release 6.2.0:--excludepypa/auditwheel#508This proposes putting a floor of
>=6.2.0onauditwheel, to be sure images here always get a sufficiently new version to support that.Notes for Reviewers
All seems to be going fine in CI... this PR is inspired by me seeing the use of wildcards fail locally using a slightly older
rapidsai/ci-wheelimage that had a slightly olderauditwheelin it.I think we'll be happy to have this protection... if some other dependency conflict resulted in
auditwheelsilently being downgraded here, it could be tough to track backwards from the failures in wheel-building CI to that being the cause.