Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] rapidfuzz wheel for python 3.10 #141

Closed
owocado opened this issue Oct 6, 2021 · 6 comments
Closed

[Feature Request] rapidfuzz wheel for python 3.10 #141

owocado opened this issue Oct 6, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@owocado
Copy link

owocado commented Oct 6, 2021

Hi there,

Since python 3.10 has been released officially now, I have moved few of my personal projects over to that version, which also makes use of rapidfuzz. From what I have tested, installing rapidfuzz through pip on a python 3.10 environment takes roughly 5 to 7 minutes, most of the time is consumed building wheel from .tar.gz. It would be great to have rapidfuzz wheel for python 3.10 to speed up install process. No rush though.

P. S. Thank you for making this wonderful project. ♥️

@maxbachmann
Copy link
Member

Hi @ow0x,

It makes sense to publish wheels for Python3.10 now that it is released. However rapidfuzz uses numpy which does not compile for Python3.10 yet (see numpy/numpy#20039). I will release a new version once numpy supports Python3.10.

Max

@maxbachmann maxbachmann added the enhancement New feature or request label Oct 6, 2021
@Akarys42
Copy link

Hey @ow0x and @maxbachmann! According to PyPI numpy now has wheels for 3.10, could we bump RapidFuzz too? :D

@maxbachmann
Copy link
Member

@Akarys42 from what I could see only wheels for arch64 and x86_64 are on pypi so far: https://pypi.org/project/numpy/#files. I added Python3.10 support on the main branch. However the build still fails due to the missing MacOs wheels (https://github.com/maxbachmann/RapidFuzz/actions/runs/1351828833)

@maxbachmann
Copy link
Member

maxbachmann commented Oct 20, 2021

@Akarys42 @ow0x Since MacOs is not relevant for most users of this library, I decided to upload them later and directly uploaded wheels for allother platforms. The Python3.10 wheels are part of the release v1.8.0.

@Akarys42
Copy link

Awesome, thank you!

@maxbachmann
Copy link
Member

Wheels for Mac Os are now released as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants