Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

Update rakefile to recommend nodejs #103

Merged
merged 4 commits into from
Apr 11, 2017

Conversation

dgreene-r7
Copy link
Contributor

@dgreene-r7 dgreene-r7 commented Apr 11, 2017

This PR changes the Rakefile to Recommend Nodejs rather than depend on it explicitly.

In the wake of regressions found in v4.8.1 we have begun a policy of only recommending installing Nodejs from package. This allows us to install Tokend while also providing the Nodejs via binary distribution or package.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.739% when pulling 83c9d0b on update-rakefile-to-recommend-nodejs into c32caa0 on master.

Copy link
Contributor

@rvanburen-r7 rvanburen-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@dgreene-r7 dgreene-r7 merged commit 23d63b9 into master Apr 11, 2017
@dgreene-r7 dgreene-r7 deleted the update-rakefile-to-recommend-nodejs branch April 11, 2017 20:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants