invoke() cannot be resolved in some cases #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output of the invoked commands may be concatenated to the output of the EOI writing command. In some situations, the chunk passed in the _write() function contains not only the EOI string but also the output of the previously executed command. This issue will make the invoke function stuck and never be resolved. Instead of comparing the chunk with the EOI string, I suggest checking if the chunk containing the EOI string.
|
Guys. i was having the exact same problem randomly. I think this fix will be really helpful. Do you know when it will be integrated in Master Branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output of the invoked commands may be concatenated to the output of the EOI writing command. In some situations, the chunk passed in the _write() function contains not only the EOI string but also the output of the previously executed command. This issue will make the invoke function is stuck and never be resolved. Instead of comparing the chunk with the EOI string, I suggest checking if the chunk containing the EOI string.