Add properties for being compatible with default calendar module broadcasting #46
Conversation
eouia
changed the title
There was a problem hiding this comment.
Thank you so much for this Pull Request! 🎉 Your contribution is highly valued.
I've left a small note for consideration in the review comments. Regardless, I appreciate your work and contribution to the project. Keep up the excellent work, and thanks again for being an active contributor! 💻🚀
Looking forward to more of your valuable inputs in the future.
There was a problem hiding this comment.
OR, I think you can fix this issue by yourself. I don't care if the properties are supported; my PR is accepted or not. :D
|
Is there any issue with this PR? |
Hi @eouia Thank you for the refactoring; the new code is definitely more concise and streamlined. I appreciate the effort! I'll be approving and merging the PR shortly. I appreciate contributors like you who help improve our project. Thank you again! |
The notifications of this module lack some fields of event, so it is not fully compatible with that of the default calendar module. Therefore, in other 3rd party modules (e.g. MMM-CalendarExt3 suites), there would be some issues.
This PR adds
startDate,endDate,titleandfullDayEventto the event which will be broadcasted.