Conversation
ericpromislow
left a comment
There was a problem hiding this comment.
The lint.yaml here is still using golangci-lint version 1.57 but steve has moved to 2.7.1 -- if you do this as well here you'll have to migrate .golangci.json to the new format.
Seeing how we're now on go 1.25 I would recommend doing that. There might be some pain involved because by default the new version complains about some lint violations that the old version let through.
|
If you want to break out the golangci-lint , I'd do the bump in another PR that gets merged first. I had to do that for K3s due to the huge list of things that it wanted to fix: Probably worth taking the time to do that, as a contributing factor to that giant K3s PR was our disabling CI lint checks a while back in order to get a release out, without opening an issue to track re-enabling them. |
I will spin-up another PR to do the golangci-lint bump. |
|
Closing in favor of #616 |
Issue: rancher/rancher#53434