Skip to content

Bump to k8s 1.35#615

Closed
crobby wants to merge 5 commits intorancher:mainfrom
crobby:k8s135
Closed

Bump to k8s 1.35#615
crobby wants to merge 5 commits intorancher:mainfrom
crobby:k8s135

Conversation

@crobby
Copy link
Copy Markdown
Contributor

@crobby crobby commented Jan 21, 2026

@crobby crobby requested a review from a team as a code owner January 21, 2026 17:09
@crobby crobby marked this pull request as draft January 21, 2026 17:10
@crobby crobby marked this pull request as ready for review January 21, 2026 18:10
Copy link
Copy Markdown
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint.yaml here is still using golangci-lint version 1.57 but steve has moved to 2.7.1 -- if you do this as well here you'll have to migrate .golangci.json to the new format.

Seeing how we're now on go 1.25 I would recommend doing that. There might be some pain involved because by default the new version complains about some lint violations that the old version let through.

@brandond
Copy link
Copy Markdown
Member

brandond commented Jan 21, 2026

If you want to break out the golangci-lint , I'd do the bump in another PR that gets merged first. I had to do that for K3s due to the huge list of things that it wanted to fix:

Probably worth taking the time to do that, as a contributing factor to that giant K3s PR was our disabling CI lint checks a while back in order to get a release out, without opening an issue to track re-enabling them.

@crobby
Copy link
Copy Markdown
Contributor Author

crobby commented Jan 22, 2026

If you want to break out the golangci-lint , I'd do the bump in another PR that gets merged first. I had to do that for K3s due to the huge list of things that it wanted to fix:

Probably worth taking the time to do that, as a contributing factor to that giant K3s PR was our disabling CI lint checks a while back in order to get a release out, without opening an issue to track re-enabling them.

I will spin-up another PR to do the golangci-lint bump.

@crobby
Copy link
Copy Markdown
Contributor Author

crobby commented Jan 23, 2026

Closing in favor of #616

@crobby crobby closed this Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants