Skip to content

Conversation

@valaparthvi
Copy link
Contributor

@valaparthvi valaparthvi commented Sep 11, 2025

kind/enhancement

What this PR does / why we need it:

This PR makes the following change:

  1. Add EKS ClusterClass example to be consumed by e2e and documentation. The template is based on templates introduced in ✨ Add ClusterClass support for EKS clusters kubernetes-sigs/cluster-api-provider-aws#5375.
  2. Add EKS ClusterClass e2e test
  3. Remove EKS cluster e2e test

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1705

Special notes for your reviewer:

Checklist:

@valaparthvi valaparthvi requested a review from a team as a code owner September 11, 2025 15:55
@valaparthvi valaparthvi added area/clusterclass kind/enhancement Categorizes issue or PR as related to a new feature. labels Sep 11, 2025
@anmazzotti
Copy link
Contributor

I miss the testing entirely. I would expect the long e2e test suite to include this new Class.
Also a related issue to document it in turtles-docs.

@valaparthvi
Copy link
Contributor Author

I miss the testing entirely. I would expect the long e2e test suite to include this new Class.

Also a related issue to document it in turtles-docs.

I will be adding them. This PR is still a WIP, I'm sorry I didn't realise it requested a review already 😅 I think it's because I didn't put it in draft.

@valaparthvi valaparthvi removed the request for review from a team September 12, 2025 05:14
@valaparthvi valaparthvi marked this pull request as draft September 12, 2025 06:51
@valaparthvi valaparthvi force-pushed the aws-eks-example branch 2 times, most recently from ca92116 to d6a0ae8 Compare September 17, 2025 06:31
@valaparthvi valaparthvi marked this pull request as ready for review September 17, 2025 06:33
@valaparthvi valaparthvi changed the title WIP: Add EKS ClusterClass example Add EKS ClusterClass example and e2e test Sep 17, 2025
@valaparthvi valaparthvi requested a review from a team September 17, 2025 08:32
@alexander-demicev
Copy link
Member

thanks!

Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. I would love to see a cleaner commit history, however changes LGTM.

@valaparthvi
Copy link
Contributor Author

valaparthvi commented Sep 17, 2025

Thank you for the PR. I would love to see a cleaner commit history, however changes LGTM.

I waited on squashing the commits in case new changes were requested to the PR. It's done now.

@valaparthvi valaparthvi merged commit 81701f9 into rancher:main Sep 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/capa area/clusterclass kind/enhancement Categorizes issue or PR as related to a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create EKS ClusterClass templates in turtles/examples/clusterclasses/aws/

5 participants