-
Couldn't load subscription status.
- Fork 31
Add EKS ClusterClass example and e2e test #1712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I miss the testing entirely. I would expect the long e2e test suite to include this new Class. |
I will be adding them. This PR is still a WIP, I'm sorry I didn't realise it requested a review already 😅 I think it's because I didn't put it in draft. |
ca92116 to
d6a0ae8
Compare
|
thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. I would love to see a cleaner commit history, however changes LGTM.
I waited on squashing the commits in case new changes were requested to the PR. It's done now. |
…usterClass Signed-off-by: Parthvi Vala <[email protected]>
d6a0ae8 to
6be808c
Compare
kind/enhancement
What this PR does / why we need it:
This PR makes the following change:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1705
Special notes for your reviewer:
Checklist: