Improving logging and error readability for rke2-uninstall.sh script#6237
Merged
dereknola merged 9 commits intorancher:masterfrom Oct 22, 2024
Merged
Improving logging and error readability for rke2-uninstall.sh script#6237dereknola merged 9 commits intorancher:masterfrom
dereknola merged 9 commits intorancher:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6237 +/- ##
=======================================
Coverage 16.62% 16.62%
=======================================
Files 32 32
Lines 3423 3423
=======================================
Hits 569 569
Misses 2812 2812
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
reviewed
Jun 25, 2024
Member
|
Please rebase your changes on top of current master. |
Signed-off-by: Jake Hyde <jakefhyde@gmail.com>
Contributor
Author
Done @brandond |
Contributor
Author
|
@brandond Can you please merge the PR if there is no further issues? |
manuelbuil
approved these changes
Sep 17, 2024
Member
|
I would probably hold off until after the current release is done, since the install script gets bundled into system-agent-installer-rke2. |
Contributor
Author
|
Okay @brandond , when is the release planned? I will remind after the release once. Thanks |
Member
|
@iamsarthakk Please resolve the conflicts (the |
dereknola
approved these changes
Oct 21, 2024
brandond
approved these changes
Oct 21, 2024
Member
|
looks like there are still conflicts. Did you pull before rebasing on top of master? |
brandond
pushed a commit
to brandond/rke2
that referenced
this pull request
Jun 13, 2025
…ancher#6237) * Added Descriptive logging and messaging in case the script fails * Removing redundant piped error * Added support for NO_COLOR env variable for default no printing of color codes * Add data-dir to uninstall and killall scripts (cherry picked from commit 721ecb2) Signed-off-by: Jake Hyde <jakefhyde@gmail.com> Co-authored-by: Sarthak Kumar <sarthak.kumar@cloudera.com> Co-authored-by: Jake Hyde <jakefhyde@gmail.com> Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
pushed a commit
to brandond/rke2
that referenced
this pull request
Jun 13, 2025
…ancher#6237) * Added Descriptive logging and messaging in case the script fails * Removing redundant piped error * Added support for NO_COLOR env variable for default no printing of color codes * Add data-dir to uninstall and killall scripts (cherry picked from commit 721ecb2) Signed-off-by: Jake Hyde <jakefhyde@gmail.com> Co-authored-by: Sarthak Kumar <sarthak.kumar@cloudera.com> Co-authored-by: Jake Hyde <jakefhyde@gmail.com> Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
pushed a commit
that referenced
this pull request
Jun 13, 2025
…6237) * Added Descriptive logging and messaging in case the script fails * Removing redundant piped error * Added support for NO_COLOR env variable for default no printing of color codes * Add data-dir to uninstall and killall scripts (cherry picked from commit 721ecb2) Signed-off-by: Jake Hyde <jakefhyde@gmail.com> Co-authored-by: Sarthak Kumar <sarthak.kumar@cloudera.com> Co-authored-by: Jake Hyde <jakefhyde@gmail.com> Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
pushed a commit
that referenced
this pull request
Jun 13, 2025
…6237) * Added Descriptive logging and messaging in case the script fails * Removing redundant piped error * Added support for NO_COLOR env variable for default no printing of color codes * Add data-dir to uninstall and killall scripts (cherry picked from commit 721ecb2) Signed-off-by: Jake Hyde <jakefhyde@gmail.com> Co-authored-by: Sarthak Kumar <sarthak.kumar@cloudera.com> Co-authored-by: Jake Hyde <jakefhyde@gmail.com> Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Currently, whenever uninstall script fails it is not immediately clear that it failed and we need to address the failure issues. These changes adds clear messaging in red colour if the script fails at any point with better logging.
It doesn't need documentation changes
Types of Changes
Improving logging and error readability in rke2-uninstall script
Verification
Changes can be verified by running the uninstall script on rancher based system
Testing
It doesn't have any changes which need unit tests or integration tests
Linked Issues
User-Facing Change
Further Comments