Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin golang.org/x/sys due to breaking API change #2204

Merged
merged 2 commits into from
Aug 18, 2020
Merged

pin golang.org/x/sys due to breaking API change #2204

merged 2 commits into from
Aug 18, 2020

Conversation

superseb
Copy link
Contributor

@superseb superseb commented Aug 18, 2020 •
edited
Loading

#1336 (comment)

Pinning golang.org/x/sys due to golang/go#34610 for Windows build failure:

# github.com/docker/docker/pkg/system
/go/pkg/mod/github.com/docker/[email protected]/pkg/system/filesys_windows.go:111:24: cannot use uintptr(unsafe.Pointer(&sd[0])) (type uintptr) as type *"golang.org/x/sys/windows".SECURITY_DESCRIPTOR in assignment

This also adds the CROSS=1 environment variable so this fails on PR, and not only on tag (publish)

@superseb superseb mentioned this pull request Aug 18, 2020
Merged
@superseb superseb merged commit 58f0005 into rancher:master Aug 18, 2020
@dil-spayne dil-spayne mentioned this pull request Oct 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luthermonson luthermonson luthermonson approved these changes

@kinarashah kinarashah kinarashah approved these changes

@ryansann ryansann Awaiting requested review from ryansann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@superseb @luthermonson @kinarashah