Fix permissions #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@unguiculus I see.
Can you update the example as well? I will merge and release a new version after. |
This is a follow-up PR for #7, since 3256bdf, unfortunately, did not fully fix the issue. The example I supplied is not ideal. It works with your fix because it uses Busybox which doesn't have group 1000 so the user runs with gid=0. I added `id` to the script which prints the following: `uid=1000 gid=0(root) groups=0(root),1000` Now, when I use an image that actually has a user with uid=1000, gid=1000, such as `jenkins/jenkins` it doesn't work because the user does not belong to group 0 in this case: `uid=1000 gid=0(root) groups=0(root),1000` This fixes the issue using `0777` as Minikube does.
|
@unguiculus Sorry, didn't see your update sooner. Github still doesn't send notification for updated commit.. Merged, thanks. |
yasker
added a commit
that referenced
this pull request
Mar 2, 2019
Thanks to Reinhard Nägele <[email protected]>, one additional PR has been merged to correctly fix #7 . See commit message and #9 for details
|
@unguiculus Local Path Provisioner v0.0.4 released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR for #7, since 3256bdf, unfortunately, did not fully fix the issue.
The example I supplied is not ideal. It works with your fix because it uses Busybox which doesn't have group 1000 so the user runs with gid=0. I added
idto the script which prints the following:uid=1000 gid=0(root) groups=0(root),1000Now, when I use an image that actually has a user with uid=1000, gid=1000, such as
jenkins/jenkinsit doesn't work because the user does not belong to group 0 in this case:uid=1000(jenkins) gid=1000(jenkins) groups=1000(jenkins)This fixes the issue using
0777as Minikube does.