Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add time to live for GCP secrets #1615

Merged
merged 1 commit into from
Oct 4, 2024
Merged

ci: add time to live for GCP secrets #1615

merged 1 commit into from
Oct 4, 2024

Conversation

juadk
Copy link
Contributor

@juadk juadk commented Oct 4, 2024

Sometimes GCP Secrets are not removed and it cost money. By adding a ttl to the secret, it is automatically deleted once expired.

image

Verification run

https://github.com/rancher/elemental/actions/runs/11177265348

@juadk juadk added the kind/QA label Oct 4, 2024
@juadk juadk self-assigned this Oct 4, 2024
@juadk juadk requested a review from a team as a code owner October 4, 2024 08:55
@juadk juadk force-pushed the add_gcp_secret_ttl branch 2 times, most recently from 85d0f47 to da3930b Compare October 4, 2024 09:10
Copy link
Contributor

@ldevulder ldevulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

Just a very small typo ;-)

.github/workflows/sub_create-runner.yaml Outdated Show resolved Hide resolved
@juadk juadk merged commit 2458d6d into main Oct 4, 2024
2 checks passed
@juadk juadk deleted the add_gcp_secret_ttl branch October 4, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants